Commit 54f919a0 authored Aug 29, 2018 by Paul Cercueil Committed by Vinod Koul Sep 11, 2018

dmaengine: dma-jz4780: Return error if not probed from DT



The driver calls clk_get() with the clock name set to NULL, which means
that the driver could only work when probed from devicetree. From now
on, we explicitly require the driver to be probed from devicetree.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Tested-by: Mathieu Malaterre <malat@debian.org>
Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent 77da5d19

drivers/dma/dma-jz4780.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -761,6 +761,11 @@ static int jz4780_dma_probe(struct platform_device *pdev)
		struct resource *res;
		int i, ret;

		if (!dev->of_node) {
		dev_err(dev, "This driver must be probed from devicetree\n");
		return -EINVAL;
		}

		jzdma = devm_kzalloc(dev, sizeof(*jzdma), GFP_KERNEL);
		if (!jzdma)
		return -ENOMEM;

Admin message