Commit 54f73df4 authored Jan 17, 2020 by Colin Ian King Committed by Alex Deucher Jan 27, 2020

drm/amd/display: fix for-loop with incorrectly sized loop counter (v2)

A for-loop is iterating from 0 up to 1000 however the loop variable count
is a u8 and hence not large enough. Fix this by making count an int.
Also remove the redundant initialization of count since this is never used
and add { } on the loop statement make the loop block clearer.

v2: drop useless else (Walter Harms)

Addresses-Coverity: ("Operands don't affect result")
Fixes: ed581a0a ("drm/amd/display: wait for update when setting dpg test pattern")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent 2cb44fb0

drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -3680,7 +3680,7 @@ static void set_crtc_test_pattern(struct dc_link *link,
		struct pipe_ctx *odm_pipe;
		enum controller_dp_color_space controller_color_space;
		int opp_cnt = 1;
		uint8_t count = 0;
		int count;

		switch (test_pattern_color_space) {
		case DP_TEST_PATTERN_COLOR_SPACE_RGB:
		@@ -3725,13 +3725,13 @@ static void set_crtc_test_pattern(struct dc_link *link,
		width,
		height);
		/* wait for dpg to blank pixel data with test pattern */
		for (count = 0; count < 1000; count++)
		for (count = 0; count < 1000; count++) {
		if (opp->funcs->dpg_is_blanked(opp))
		break;
		else
		udelay(100);
		}
		}
		}
		break;
		case DP_TEST_PATTERN_VIDEO_MODE:
		{

Admin message