Commit 54f63d9d authored Jul 11, 2019 by Uladzislau Rezki (Sony) Committed by Linus Torvalds Jul 12, 2019

mm/vmalloc.c: get rid of one single unlink_va() when merge

It does not make sense to try to "unlink" the node that is definitely not
linked with a list nor tree.  On the first merge step VA just points to
the previously disconnected busy area.

On the second step, check if the node has been merged and do "unlink" if
so, because now it points to an object that must be linked.

Link: http://lkml.kernel.org/r/20190606120411.8298-4-urezki@gmail.com


Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
Acked-by: Hillf Danton <hdanton@sina.com>
Reviewed-by: Roman Gushchin <guro@fb.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Oleksiy Avramchenko <oleksiy.avramchenko@sonymobile.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 82dd23e8

mm/vmalloc.c

+2 −6

Original line number	Diff line number	Diff line
		@@ -719,9 +719,6 @@ merge_or_add_vmap_area(struct vmap_area *va,
		/* Check and update the tree if needed. */
		augment_tree_propagate_from(sibling);

		/* Remove this VA, it has been merged. */
		unlink_va(va, root);

		/* Free vmap_area object. */
		kmem_cache_free(vmap_area_cachep, va);

		@@ -746,12 +743,11 @@ merge_or_add_vmap_area(struct vmap_area *va,
		/* Check and update the tree if needed. */
		augment_tree_propagate_from(sibling);

		/* Remove this VA, it has been merged. */
		if (merged)
		unlink_va(va, root);

		/* Free vmap_area object. */
		kmem_cache_free(vmap_area_cachep, va);

		return;
		}
		}

Admin message