xfs: tidy up xfs_set_inode32 (54aa61f8) · Commits · 戴 / test

xfs_set_inode32() caught my eye because it had weird spacing around the "-1's". In cleaning that up, I realized that the assignment in the declaration of "ino" is never used; it's rewritten before it gets read. Drop the ino initializer from its declaration since it's not used, and move the agino initialization into the body of the function, mostly so that we can have pretty whitespace and not exceed 80 columns. :) Signed-off-by:

Eric Sandeen <sandeen@redhat.com> Reviewed-by:

Brian Foster <bfoster@redhat.com> Signed-off-by:

Dave Chinner <david@fromorbit.com>

fs/xfs/xfs_super.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -609,8 +609,8 @@ xfs_set_inode32(struct xfs_mount *mp, xfs_agnumber_t agcount)
		xfs_agnumber_t maxagi = 0;
		xfs_sb_t *sbp = &mp->m_sb;
		xfs_agnumber_t max_metadata;
		xfs_agino_t agino = XFS_OFFBNO_TO_AGINO(mp, sbp->sb_agblocks -1, 0);
		xfs_ino_t ino = XFS_AGINO_TO_INO(mp, sbp->sb_agcount -1, agino);
		xfs_agino_t agino;
		xfs_ino_t ino;
		xfs_perag_t *pag;

		/* Calculate how much should be reserved for inodes to meet
		@@ -628,6 +628,8 @@ xfs_set_inode32(struct xfs_mount *mp, xfs_agnumber_t agcount)
		max_metadata = agcount;
		}

		agino = XFS_OFFBNO_TO_AGINO(mp, sbp->sb_agblocks - 1, 0);

		for (index = 0; index < agcount; index++) {
		ino = XFS_AGINO_TO_INO(mp, index, agino);

Admin message