Commit 54a7151b authored Mar 27, 2019 by Fredrik Noring Committed by Masahiro Yamada Mar 28, 2019

kbuild: modversions: Fix relative CRC byte order interpretation

Fix commit 56067812 ("kbuild: modversions: add infrastructure for
emitting relative CRCs") where CRCs are interpreted in host byte order
rather than proper kernel byte order. The bug is conditional on
CONFIG_MODULE_REL_CRCS.

For example, when loading a BE module into a BE kernel compiled with a LE
system, the error "disagrees about version of symbol module_layout" is
produced. A message such as "Found checksum D7FA6856 vs module 5668FAD7"
will be given with debug enabled, which indicates an obvious endian
problem within __kcrctab within the kernel image.

The general solution is to use the macro TO_NATIVE, as is done in
similar cases throughout modpost.c. With this correction it has been
verified that a BE kernel compiled with a LE system accepts BE modules.

This change has also been verified with a LE kernel compiled with a LE
system, in which case TO_NATIVE returns its value unmodified since the
byte orders match. This is by far the common case.

Fixes: 56067812 ("kbuild: modversions: add infrastructure for emitting relative CRCs")
Signed-off-by: Fredrik Noring <noring@nocrew.org>
Cc: stable@vger.kernel.org
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

parent 7fcddf7c

scripts/mod/modpost.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -639,7 +639,7 @@ static void handle_modversions(struct module mod, struct elf_info info,
		info->sechdrs[sym->st_shndx].sh_offset -
		(info->hdr->e_type != ET_REL ?
		info->sechdrs[sym->st_shndx].sh_addr : 0);
		crc = *crcp;
		crc = TO_NATIVE(*crcp);
		}
		sym_update_crc(symname + strlen("__crc_"), mod, crc,
		export);

Admin message