Commit 54a485e9 authored by Mike Marciniszyn's avatar Mike Marciniszyn Committed by Jason Gunthorpe
Browse files

IB/rdmavt: Fix RQ counting issues causing use of an invalid RWQE 

The lookaside count is improperly initialized to the size of the
Receive Queue with the additional +1.  In the traces below, the
RQ size is 384, so the count was set to 385.

The lookaside count is then rarely refreshed.  Note the high and
incorrect count in the trace below:

rvt_get_rwqe: [hfi1_0] wqe ffffc900078e9008 wr_id 55c7206d75a0 qpn c
	qpt 2 pid 3018 num_sge 1 head 1 tail 0, count 385
rvt_get_rwqe: (hfi1_rc_rcv+0x4eb/0x1480 [hfi1] <- rvt_get_rwqe) ret=0x1

The head,tail indicate there is only one RWQE posted although the count
says 385 and we correctly return the element 0.

The next call to rvt_get_rwqe with the decremented count:

rvt_get_rwqe: [hfi1_0] wqe ffffc900078e9058 wr_id 0 qpn c
	qpt 2 pid 3018 num_sge 0 head 1 tail 1, count 384
rvt_get_rwqe: (hfi1_rc_rcv+0x4eb/0x1480 [hfi1] <- rvt_get_rwqe) ret=0x1

Note that the RQ is empty (head == tail) yet we return the RWQE at tail 1,
which is not valid because of the bogus high count.

Best case, the RWQE has never been posted and the rc logic sees an RWQE
that is too small (all zeros) and puts the QP into an error state.

In the worst case, a server slow at posting receive buffers might fool
rvt_get_rwqe() into fetching an old RWQE and corrupt memory.

Fix by deleting the faulty initialization code and creating an
inline to fetch the posted count and convert all callers to use
new inline.

Fixes: f592ae3c ("IB/rdmavt: Fracture single lock used for posting and processing RWQEs")
Link: https://lore.kernel.org/r/20200728183848.22226.29132.stgit@awfm-01.aw.intel.com


Reported-by: default avatarZhaojuan Guo <zguo@redhat.com>
Cc: <stable@vger.kernel.org> # 5.4.x
Reviewed-by: default avatarKaike Wan <kaike.wan@intel.com>
Signed-off-by: default avatarMike Marciniszyn <mike.marciniszyn@intel.com>
Tested-by: default avatarHonggang Li <honli@redhat.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 81530ab0

drivers/infiniband/sw/rdmavt/qp.c

+4 −29
Original line number Diff line number Diff line
@@ -901,8 +901,6 @@ static void rvt_init_qp(struct rvt_dev_info *rdi, struct rvt_qp *qp, 
	qp->s_tail_ack_queue = 0;

	qp->s_acked_ack_queue = 0;

	qp->s_num_rd_atomic = 0;

	if (qp->r_rq.kwq)

		qp->r_rq.kwq->count = qp->r_rq.size;

	qp->r_sge.num_sge = 0;

	atomic_set(&qp->s_reserved_used, 0);

}
@@ -2366,31 +2364,6 @@ bad_lkey: 
	return 0;

}



/**

 * get_count - count numbers of request work queue entries

 * in circular buffer

 * @rq: data structure for request queue entry

 * @tail: tail indices of the circular buffer

 * @head: head indices of the circular buffer

 *

 * Return - total number of entries in the circular buffer

 */

static u32 get_count(struct rvt_rq *rq, u32 tail, u32 head)

{

	u32 count;



	count = head;



	if (count >= rq->size)

		count = 0;

	if (count < tail)

		count += rq->size - tail;

	else

		count -= tail;



	return count;

}



/**

 * get_rvt_head - get head indices of the circular buffer

 * @rq: data structure for request queue entry
@@ -2465,7 +2438,7 @@ int rvt_get_rwqe(struct rvt_qp *qp, bool wr_id_only) 


	if (kwq->count < RVT_RWQ_COUNT_THRESHOLD) {

		head = get_rvt_head(rq, ip);

		kwq->count = get_count(rq, tail, head);

		kwq->count = rvt_get_rq_count(rq, head, tail);

	}

	if (unlikely(kwq->count == 0)) {

		ret = 0;
@@ -2500,7 +2473,9 @@ int rvt_get_rwqe(struct rvt_qp *qp, bool wr_id_only) 
		 * the number of remaining WQEs.

		 */

		if (kwq->count < srq->limit) {

			kwq->count = get_count(rq, tail, get_rvt_head(rq, ip));

			kwq->count =

				rvt_get_rq_count(rq,

						 get_rvt_head(rq, ip), tail);

			if (kwq->count < srq->limit) {

				struct ib_event ev;

drivers/infiniband/sw/rdmavt/rc.c

+1 −3
Original line number Diff line number Diff line
@@ -127,9 +127,7 @@ __be32 rvt_compute_aeth(struct rvt_qp *qp) 
			 * not atomic, which is OK, since the fuzziness is

			 * resolved as further ACKs go out.

			 */

			credits = head - tail;

			if ((int)credits < 0)

				credits += qp->r_rq.size;

			credits = rvt_get_rq_count(&qp->r_rq, head, tail);

		}

		/*

		 * Binary search the credit table to find the code to

include/rdma/rdmavt_qp.h

+19 −0
Original line number Diff line number Diff line
@@ -305,6 +305,25 @@ struct rvt_rq { 
	spinlock_t lock ____cacheline_aligned_in_smp;

};



/**

 * rvt_get_rq_count - count numbers of request work queue entries

 * in circular buffer

 * @rq: data structure for request queue entry

 * @head: head indices of the circular buffer

 * @tail: tail indices of the circular buffer

 *

 * Return - total number of entries in the Receive Queue

 */



static inline u32 rvt_get_rq_count(struct rvt_rq *rq, u32 head, u32 tail)

{

	u32 count = head - tail;



	if ((s32)count < 0)

		count += rq->size;

	return count;

}



/*

 * This structure holds the information that the send tasklet needs

 * to send a RDMA read response or atomic operation.

CRA Git | Maintained and supported by SUSTech CRA and CCSE