Commit 54a44d54 authored by Nikita Yushchenko's avatar Nikita Yushchenko Committed by Greg Kroah-Hartman
Browse files

tty: serial: fsl_lpuart: fix del_timer_sync() vs timer routine deadlock 



Problem found via lockdep:

- lpuart_set_termios() calls del_timer_sync(&sport->lpuart_timer) while
  holding sport->port.lock

- sport->lpuart_timer routine is lpuart_timer_func() that calls
  lpuart_copy_rx_to_tty() that acquires same lock.

To fix, move Rx DMA stopping out of lock, as it already is in other places
in the same file.

While at it, also make Rx DMA start/stop code to look the same is in
other places in the same file.

Signed-off-by: default avatarNikita Yushchenko <nikita.yoush@cogentembedded.com>
Tested-by: default avatarStefan Agner <stefan@agner.ch>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 623ac1d4

drivers/tty/serial/fsl_lpuart.c

+17 −18
Original line number Diff line number Diff line
@@ -1407,6 +1407,18 @@ lpuart_set_termios(struct uart_port *port, struct ktermios *termios, 
	/* ask the core to calculate the divisor */

	baud = uart_get_baud_rate(port, termios, old, 50, port->uartclk / 16);



	/*

	 * Need to update the Ring buffer length according to the selected

	 * baud rate and restart Rx DMA path.

	 *

	 * Since timer function acqures sport->port.lock, need to stop before

	 * acquring same lock because otherwise del_timer_sync() can deadlock.

	 */

	if (old && sport->lpuart_dma_rx_use) {

		del_timer_sync(&sport->lpuart_timer);

		lpuart_dma_rx_free(&sport->port);

	}



	spin_lock_irqsave(&sport->port.lock, flags);



	sport->port.read_status_mask = 0;
@@ -1456,23 +1468,12 @@ lpuart_set_termios(struct uart_port *port, struct ktermios *termios, 
	/* restore control register */

	writeb(old_cr2, sport->port.membase + UARTCR2);



	/*

	 * If new baud rate is set, we will also need to update the Ring buffer

	 * length according to the selected baud rate and restart Rx DMA path.

	 */

	if (old) {

		if (sport->lpuart_dma_rx_use) {

			del_timer_sync(&sport->lpuart_timer);

			lpuart_dma_rx_free(&sport->port);

		}



		if (sport->dma_rx_chan && !lpuart_start_rx_dma(sport)) {

			sport->lpuart_dma_rx_use = true;

	if (old && sport->lpuart_dma_rx_use) {

		if (!lpuart_start_rx_dma(sport))

			rx_dma_timer_init(sport);

		} else {

		else

			sport->lpuart_dma_rx_use = false;

	}

	}



	spin_unlock_irqrestore(&sport->port.lock, flags);

}
@@ -2131,14 +2132,12 @@ static int lpuart_resume(struct device *dev) 


	if (sport->lpuart_dma_rx_use) {

		if (sport->port.irq_wake) {

			if (!lpuart_start_rx_dma(sport)) {

				sport->lpuart_dma_rx_use = true;

			if (!lpuart_start_rx_dma(sport))

				rx_dma_timer_init(sport);

			} else {

			else

				sport->lpuart_dma_rx_use = false;

		}

	}

	}



	if (sport->dma_tx_chan && !lpuart_dma_tx_request(&sport->port)) {

			init_waitqueue_head(&sport->dma_wait);

CRA Git | Maintained and supported by SUSTech CRA and CCSE