Add param ops struct for hvc_iucv driver. (549a8a03) · Commits · 戴 / test

Today's next 20091117 build failed on s390 with drivers/char/hvc_iucv.c:1331: error: 'param_ops_vmidfilter' undeclared here (not in a function) make[2]: *** [drivers/char/hvc_iucv.o] Error 1 Most probably caused by commit 684a6d340b8a5767db4670031b0f39455346018a (param:param_ops) which introduced a param_ops structure. The following compile tested patch adds a param_ops structure for hvc_iucv. Signed-off-by:

Sachin Sant <sachinp@in.ibm.com> Acked-by:

Heiko Carstens <heiko.carstens@de.ibm.com> Tested-by:

Phil Carmody <ext-phil.2.carmody@nokia.com> Signed-off-by:

Rusty Russell <rusty@rustcorp.com.au>

drivers/char/hvc_iucv.c

+7 −2

Original line number	Diff line number	Diff line
		@@ -1149,7 +1149,7 @@ out_err:
		* Note: If it is called early in the boot process, @val is stored and
		* parsed later in hvc_iucv_init().
		*/
		static int param_set_vmidfilter(const char val, struct kernel_param kp)
		static int param_set_vmidfilter(const char val, const struct kernel_param kp)
		{
		int rc;

		@@ -1176,7 +1176,7 @@ static int param_set_vmidfilter(const char val, struct kernel_param kp)
		* The function stores the filter as a comma-separated list of z/VM user IDs
		* in @buffer. Typically, sysfs routines call this function for attr show.
		*/
		static int param_get_vmidfilter(char buffer, struct kernel_param kp)
		static int param_get_vmidfilter(char buffer, const struct kernel_param kp)
		{
		int rc;
		size_t index, len;
		@@ -1203,6 +1203,11 @@ static int param_get_vmidfilter(char buffer, struct kernel_param kp)

		#define param_check_vmidfilter(name, p) __param_check(name, p, void)

		static struct kernel_param_ops param_ops_vmidfilter = {
		.set = param_set_vmidfilter,
		.get = param_get_vmidfilter,
		};

		/**
		* hvc_iucv_init() - z/VM IUCV HVC device driver initialization
		*/

Admin message