Commit 549381e1 authored May 29, 2012 by Johannes Weiner Committed by Linus Torvalds May 29, 2012

mm: bootmem: remove redundant offset check when finally freeing bootmem



When bootmem releases an unaligned BITS_PER_LONG pages chunk of memory
to the page allocator, it checks the bitmap if there are still
unreserved pages in the chunk (set bits), but also if the offset in the
chunk indicates BITS_PER_LONG loop iterations already.

But since the consulted bitmap is only a one-word-excerpt of the full
per-node bitmap, there can not be more than BITS_PER_LONG bits set in
it.  The additional offset check is unnecessary.

Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Tejun Heo <tj@kernel.org>
Acked-by: David S. Miller <davem@davemloft.net>
Cc: Yinghai Lu <yinghai@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 6dccdcbe

mm/bootmem.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -204,7 +204,7 @@ static unsigned long __init free_all_bootmem_core(bootmem_data_t *bdata)
		unsigned long off = 0;

		vec >>= start & (BITS_PER_LONG - 1);
		while (vec && off < BITS_PER_LONG) {
		while (vec) {
		if (vec & 1) {
		page = pfn_to_page(start + off);
		__free_pages_bootmem(page, 0);

Admin message