Commit 548c8933 authored by Hannes Eder's avatar Hannes Eder Committed by Ingo Molnar
Browse files

kernel/irq: fix sparse warning: make symbol static 



While being at it make every occurrence of 'do_irq_select_affinity'
have the same signature in terms of signedness of the first argument.

Fix this sparse warning:
  kernel/irq/manage.c:112:5: warning: symbol 'do_irq_select_affinity' was not declared. Should it be static?

Also rename do_irq_select_affinity() to setup_affinity() - shorter name
and clearer naming.

Signed-off-by: default avatarHannes Eder <hannes@hanneseder.net>
Acked-by: default avatarMatthew Wilcox <matthew@wil.cx>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent d5b56233

kernel/irq/manage.c

+5 −5
Original line number Diff line number Diff line
@@ -109,7 +109,7 @@ int irq_set_affinity(unsigned int irq, const struct cpumask *cpumask) 
/*

 * Generic version of the affinity autoselector.

 */

int do_irq_select_affinity(unsigned int irq, struct irq_desc *desc)

static int setup_affinity(unsigned int irq, struct irq_desc *desc)

{

	if (!irq_can_set_affinity(irq))

		return 0;
@@ -133,7 +133,7 @@ set_affinity: 
	return 0;

}

#else

static inline int do_irq_select_affinity(unsigned int irq, struct irq_desc *d)

static inline int setup_affinity(unsigned int irq, struct irq_desc *d)

{

	return irq_select_affinity(irq);

}
@@ -149,14 +149,14 @@ int irq_select_affinity_usr(unsigned int irq) 
	int ret;



	spin_lock_irqsave(&desc->lock, flags);

	ret = do_irq_select_affinity(irq, desc);

	ret = setup_affinity(irq, desc);

	spin_unlock_irqrestore(&desc->lock, flags);



	return ret;

}



#else

static inline int do_irq_select_affinity(int irq, struct irq_desc *desc)

static inline int setup_affinity(unsigned int irq, struct irq_desc *desc)

{

	return 0;

}
@@ -488,7 +488,7 @@ __setup_irq(unsigned int irq, struct irq_desc * desc, struct irqaction *new) 
			desc->status |= IRQ_NO_BALANCING;



		/* Set default affinity mask once everything is setup */

		do_irq_select_affinity(irq, desc);

		setup_affinity(irq, desc);



	} else if ((new->flags & IRQF_TRIGGER_MASK)

			&& (new->flags & IRQF_TRIGGER_MASK)

CRA Git | Maintained and supported by SUSTech CRA and CCSE