Commit 5474ca7d authored Dec 12, 2019 by Jan Kara

reiserfs: Fix memory leak of journal device string



When a filesystem is mounted with jdev mount option, we store the
journal device name in an allocated string in superblock. However we
fail to ever free that string. Fix it.

Reported-by:  <syzbot+1c6756baf4b16b94d2a6@syzkaller.appspotmail.com>
Fixes: c3aa0776 ("reiserfs: Properly display mount options in /proc/mounts")
CC: stable@vger.kernel.org
Signed-off-by: Jan Kara <jack@suse.cz>

parent 34e92542

fs/reiserfs/super.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -629,6 +629,7 @@ static void reiserfs_put_super(struct super_block *s)
		reiserfs_write_unlock(s);
		mutex_destroy(&REISERFS_SB(s)->lock);
		destroy_workqueue(REISERFS_SB(s)->commit_wq);
		kfree(REISERFS_SB(s)->s_jdev);
		kfree(s->s_fs_info);
		s->s_fs_info = NULL;
		}
		@@ -2240,6 +2241,7 @@ error_unlocked:
		kfree(qf_names[j]);
		}
		#endif
		kfree(sbi->s_jdev);
		kfree(sbi);

		s->s_fs_info = NULL;

Admin message