Commit 5473a7bd authored by Vasundhara Volam's avatar Vasundhara Volam Committed by David S. Miller
Browse files

devlink: Add support for driverinit set value for devlink_port 



Add support for "driverinit" configuration mode value for devlink_port
configuration parameters. Add devlink_port_param_driverinit_value_set()
function to help the driver set the value to devlink_port.

Also, move the common code to __devlink_param_driverinit_value_set()
to be used by both device and port params.

v7->v8:
Re-order the definitions as follows:
__devlink_param_driverinit_value_get
__devlink_param_driverinit_value_set
devlink_param_driverinit_value_get
devlink_param_driverinit_value_set
devlink_port_param_driverinit_value_get
devlink_port_param_driverinit_value_set

Cc: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarVasundhara Volam <vasundhara-v.volam@broadcom.com>
Acked-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ffd19b9a

include/net/devlink.h

+11 −0
Original line number Original line Diff line number Diff line
@@ -582,6 +582,9 @@ int 
devlink_port_param_driverinit_value_get(struct devlink_port *devlink_port,

devlink_port_param_driverinit_value_get(struct devlink_port *devlink_port,

					u32 param_id,

					u32 param_id,

					union devlink_param_value *init_val);

					union devlink_param_value *init_val);

int devlink_port_param_driverinit_value_set(struct devlink_port *devlink_port,

					    u32 param_id,

					    union devlink_param_value init_val);

void devlink_param_value_changed(struct devlink *devlink, u32 param_id);

void devlink_param_value_changed(struct devlink *devlink, u32 param_id);

void devlink_param_value_str_fill(union devlink_param_value *dst_val,

void devlink_param_value_str_fill(union devlink_param_value *dst_val,

				  const char *src);

				  const char *src);
@@ -839,6 +842,14 @@ devlink_port_param_driverinit_value_get(struct devlink_port *devlink_port, 
	return -EOPNOTSUPP;

	return -EOPNOTSUPP;

}

}





static inline int

devlink_port_param_driverinit_value_set(struct devlink_port *devlink_port,

					u32 param_id,

					union devlink_param_value init_val)

{

	return -EOPNOTSUPP;

}



static inline void

static inline void

devlink_param_value_changed(struct devlink *devlink, u32 param_id)

devlink_param_value_changed(struct devlink *devlink, u32 param_id)

{

{

net/core/devlink.c

+52 −18
Original line number Original line Diff line number Diff line
@@ -4737,6 +4737,32 @@ __devlink_param_driverinit_value_get(struct list_head *param_list, u32 param_id, 
	return 0;

	return 0;

}

}





static int

__devlink_param_driverinit_value_set(struct devlink *devlink,

				     struct list_head *param_list, u32 param_id,

				     union devlink_param_value init_val,

				     enum devlink_command cmd)

{

	struct devlink_param_item *param_item;



	param_item = devlink_param_find_by_id(param_list, param_id);

	if (!param_item)

		return -EINVAL;



	if (!devlink_param_cmode_is_supported(param_item->param,

					      DEVLINK_PARAM_CMODE_DRIVERINIT))

		return -EOPNOTSUPP;



	if (param_item->param->type == DEVLINK_PARAM_TYPE_STRING)

		strcpy(param_item->driverinit_value.vstr, init_val.vstr);

	else

		param_item->driverinit_value = init_val;

	param_item->driverinit_value_valid = true;



	devlink_param_notify(devlink, param_item, DEVLINK_CMD_PARAM_NEW);

	return 0;

}



/**

/**

 *	devlink_param_driverinit_value_get - get configuration parameter

 *	devlink_param_driverinit_value_get - get configuration parameter

 *					     value for driver initializing

 *					     value for driver initializing
@@ -4774,24 +4800,10 @@ EXPORT_SYMBOL_GPL(devlink_param_driverinit_value_get); 
int devlink_param_driverinit_value_set(struct devlink *devlink, u32 param_id,

int devlink_param_driverinit_value_set(struct devlink *devlink, u32 param_id,

				       union devlink_param_value init_val)

				       union devlink_param_value init_val)

{

{

	struct devlink_param_item *param_item;

	return __devlink_param_driverinit_value_set(devlink,



						    &devlink->param_list,

	param_item = devlink_param_find_by_id(&devlink->param_list, param_id);

						    param_id, init_val,

	if (!param_item)

						    DEVLINK_CMD_PARAM_NEW);

		return -EINVAL;



	if (!devlink_param_cmode_is_supported(param_item->param,

					      DEVLINK_PARAM_CMODE_DRIVERINIT))

		return -EOPNOTSUPP;



	if (param_item->param->type == DEVLINK_PARAM_TYPE_STRING)

		strcpy(param_item->driverinit_value.vstr, init_val.vstr);

	else

		param_item->driverinit_value = init_val;

	param_item->driverinit_value_valid = true;



	devlink_param_notify(devlink, param_item, DEVLINK_CMD_PARAM_NEW);

	return 0;

}

}

EXPORT_SYMBOL_GPL(devlink_param_driverinit_value_set);

EXPORT_SYMBOL_GPL(devlink_param_driverinit_value_set);
@@ -4820,6 +4832,28 @@ int devlink_port_param_driverinit_value_get(struct devlink_port *devlink_port, 
}

}

EXPORT_SYMBOL_GPL(devlink_port_param_driverinit_value_get);

EXPORT_SYMBOL_GPL(devlink_port_param_driverinit_value_get);





/**

 *     devlink_port_param_driverinit_value_set - set value of configuration

 *                                               parameter for driverinit

 *                                               configuration mode

 *

 *     @devlink_port: devlink_port

 *     @param_id: parameter ID

 *     @init_val: value of parameter to set for driverinit configuration mode

 *

 *     This function should be used by the driver to set driverinit

 *     configuration mode default value.

 */

int devlink_port_param_driverinit_value_set(struct devlink_port *devlink_port,

					    u32 param_id,

					    union devlink_param_value init_val)

{

	return __devlink_param_driverinit_value_set(devlink_port->devlink,

						    &devlink_port->param_list,

						    param_id, init_val, 0);

}

EXPORT_SYMBOL_GPL(devlink_port_param_driverinit_value_set);



/**

/**

 *	devlink_param_value_changed - notify devlink on a parameter's value

 *	devlink_param_value_changed - notify devlink on a parameter's value

 *				      change. Should be called by the driver

 *				      change. Should be called by the driver

CRA Git | Maintained and supported by SUSTech CRA and CCSE