Commit 54632f02 authored Apr 30, 2018 by Eric Biggers Committed by Theodore Ts'o May 20, 2018

fscrypt: drop max_namelen check from fname_decrypt()



fname_decrypt() returns an error if the input filename is longer than
the inode's ->max_namelen() as given by the filesystem.  But, this
doesn't actually make sense because the filesystem provided the input
filename in the first place, where it was subject to the filesystem's
limits.  And fname_decrypt() has no internal limit itself.

Thus, remove this unnecessary check.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

parent 17bfde60

fs/crypto/fname.c

+2 −5

Original line number	Diff line number	Diff line
		@@ -93,14 +93,11 @@ static int fname_decrypt(struct inode *inode,
		struct skcipher_request *req = NULL;
		DECLARE_CRYPTO_WAIT(wait);
		struct scatterlist src_sg, dst_sg;
		struct fscrypt_info *ci = inode->i_crypt_info;
		struct crypto_skcipher *tfm = ci->ci_ctfm;
		struct crypto_skcipher *tfm = inode->i_crypt_info->ci_ctfm;
		int res = 0;
		char iv[FS_CRYPTO_BLOCK_SIZE];
		unsigned lim;

		lim = inode->i_sb->s_cop->max_namelen(inode);
		if (iname->len <= 0 \|\| iname->len > lim)
		if (iname->len <= 0)
		return -EIO;

		/* Allocate request */

Admin message