Commit 543b921b authored by Arend Van Spriel's avatar Arend Van Spriel Committed by Johannes Berg
Browse files

cfg80211: get rid of name indirection trick for ieee80211_get_channel() 



The comment on the name indirection suggested an issue but turned out
to be untrue. Digging in older kernel version showed issue with ipw2x00
but that is no longer true so get rid on the name indirection.

Signed-off-by: default avatarArend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 74204f8f

drivers/net/wireless/ath/ath10k/htt_rx.c

+1 −2
Original line number Diff line number Diff line
@@ -2451,8 +2451,7 @@ bool ath10k_htt_t2h_msg_handler(struct ath10k *ar, struct sk_buff *skb) 
		u32 phymode = __le32_to_cpu(resp->chan_change.phymode);

		u32 freq = __le32_to_cpu(resp->chan_change.freq);



		ar->tgt_oper_chan =

			__ieee80211_get_channel(ar->hw->wiphy, freq);

		ar->tgt_oper_chan = ieee80211_get_channel(ar->hw->wiphy, freq);

		ath10k_dbg(ar, ATH10K_DBG_HTT,

			   "htt chan change freq %u phymode %s\n",

			   freq, ath10k_wmi_phymode_str(phymode));

drivers/net/wireless/marvell/mwifiex/cfg80211.c

+1 −1
Original line number Diff line number Diff line
@@ -2078,7 +2078,7 @@ static int mwifiex_cfg80211_inform_ibss_bss(struct mwifiex_private *priv) 
	ie_len = ie_buf[1] + sizeof(struct ieee_types_header);



	band = mwifiex_band_to_radio_type(priv->curr_bss_params.band);

	chan = __ieee80211_get_channel(priv->wdev.wiphy,

	chan = ieee80211_get_channel(priv->wdev.wiphy,

			ieee80211_channel_to_frequency(bss_info.bss_chan,

						       band));

include/net/cfg80211.h

+3 −14
Original line number Diff line number Diff line
@@ -3955,26 +3955,15 @@ int ieee80211_channel_to_frequency(int chan, enum nl80211_band band); 
 */

int ieee80211_frequency_to_channel(int freq);



/*

 * Name indirection necessary because the ieee80211 code also has

 * a function named "ieee80211_get_channel", so if you include

 * cfg80211's header file you get cfg80211's version, if you try

 * to include both header files you'll (rightfully!) get a symbol

 * clash.

 */

struct ieee80211_channel *__ieee80211_get_channel(struct wiphy *wiphy,

						  int freq);

/**

 * ieee80211_get_channel - get channel struct from wiphy for specified frequency

 *

 * @wiphy: the struct wiphy to get the channel for

 * @freq: the center frequency of the channel

 *

 * Return: The channel struct from @wiphy at @freq.

 */

static inline struct ieee80211_channel *

ieee80211_get_channel(struct wiphy *wiphy, int freq)

{

	return __ieee80211_get_channel(wiphy, freq);

}

struct ieee80211_channel *ieee80211_get_channel(struct wiphy *wiphy, int freq);



/**

 * ieee80211_get_response_rate - get basic rate for a given rate

net/wireless/util.c

+2 −3
Original line number Diff line number Diff line
@@ -114,8 +114,7 @@ int ieee80211_frequency_to_channel(int freq) 
}

EXPORT_SYMBOL(ieee80211_frequency_to_channel);



struct ieee80211_channel *__ieee80211_get_channel(struct wiphy *wiphy,

						  int freq)

struct ieee80211_channel *ieee80211_get_channel(struct wiphy *wiphy, int freq)

{

	enum nl80211_band band;

	struct ieee80211_supported_band *sband;
@@ -135,7 +134,7 @@ struct ieee80211_channel *__ieee80211_get_channel(struct wiphy *wiphy, 


	return NULL;

}

EXPORT_SYMBOL(__ieee80211_get_channel);

EXPORT_SYMBOL(ieee80211_get_channel);



static void set_mandatory_flags_band(struct ieee80211_supported_band *sband,

				     enum nl80211_band band)

CRA Git | Maintained and supported by SUSTech CRA and CCSE