Commit 54364b75 authored Jun 29, 2008 by Krzysztof Halasa Committed by Jeff Garzik Jul 04, 2008

Add missing skb->dev assignment in Frame Relay RX code



Commit 4c13eb66 ([ETH]: Make
eth_type_trans set skb->dev like the other *_type_trans) removed
skb->dev assignment from hdlc_fr.c:fr_rx(). Unfortunately it was also
needed for cases other than eth_type_trans().

Adding it back.

It's quite serious and may be a security risk as it causes a wrong
input interface indication (the physical hdlcX instead of logical
pvcX). Probably -stable class fix.

Signed-off-by: Krzysztof Halasa <khc@pm.waw.pl>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

parent ab1b2046

drivers/net/wan/hdlc_fr.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1008,6 +1008,7 @@ static int fr_rx(struct sk_buff *skb)
		stats->rx_bytes += skb->len;
		if (pvc->state.becn)
		stats->rx_compressed++;
		skb->dev = dev;
		netif_rx(skb);
		return NET_RX_SUCCESS;
		} else {

Admin message