Commit 543094e1 authored May 20, 2020 by Vishal Verma Committed by Dan Williams Jun 17, 2020

nvdimm/region: always show the 'align' attribute



It is possible that a platform that is capable of 'namespace labels'
comes up without the labels properly initialized. In this case, the
region's 'align' attribute is hidden. Howerver, once the user does
initialize he labels, the 'align' attribute still stays hidden, which is
unexpected.

The sysfs_update_group() API is meant to address this, and could be
called during region probe, but it has entanglements with the device
'lockdep_mutex'. Therefore, simply make the 'align' attribute always
visible. It doesn't matter what it says for label-less namespaces, since
it is not possible to change their allocation anyway.

Suggested-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Link: https://lore.kernel.org/r/20200520225026.29426-1-vishal.l.verma@intel.com


Signed-off-by: Dan Williams <dan.j.williams@intel.com>

parent b3a9e3b9

drivers/nvdimm/region_devs.c

+2 −12

Original line number	Diff line number	Diff line
		@@ -679,18 +679,8 @@ static umode_t region_visible(struct kobject kobj, struct attribute a, int n)
		return a->mode;
		}

		if (a == &dev_attr_align.attr) {
		int i;

		for (i = 0; i < nd_region->ndr_mappings; i++) {
		struct nd_mapping *nd_mapping = &nd_region->mapping[i];
		struct nvdimm *nvdimm = nd_mapping->nvdimm;

		if (test_bit(NDD_LABELING, &nvdimm->flags))
		if (a == &dev_attr_align.attr)
		return a->mode;
		}
		return 0;
		}

		if (a != &dev_attr_set_cookie.attr
		&& a != &dev_attr_available_size.attr)

Admin message