spi: Move queue data structure initialisation to main master init (5424d43e) · Commits · 戴 / test

Since most devices now do use the standard queue and in order to avoid initialisation ordering issues being introduced by further refactorings to improve performance move the initialisation of the queue and the lock for it to the main master allocation. Signed-off-by:

Mark Brown <broonie@kernel.org>

drivers/spi/spi.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -989,9 +989,6 @@ static int spi_init_queue(struct spi_master *master)
		{
		struct sched_param param = { .sched_priority = MAX_RT_PRIO - 1 };

		INIT_LIST_HEAD(&master->queue);
		spin_lock_init(&master->queue_lock);

		master->running = false;
		master->busy = false;

		@@ -1595,6 +1592,8 @@ int spi_register_master(struct spi_master *master)
		dynamic = 1;
		}

		INIT_LIST_HEAD(&master->queue);
		spin_lock_init(&master->queue_lock);
		spin_lock_init(&master->bus_lock_spinlock);
		mutex_init(&master->bus_lock_mutex);
		master->bus_lock_flag = 0;

Admin message