Commit 541b647a authored Aug 07, 2018 by Mauro Carvalho Chehab

media: exynos-gsc: fix return code if mutex was interrupted

All poll routines expect a poll flag, and not error codes. So,
instead of returning -ERESTARTSYS if the mutex got interrupted,
return EPOLERR, just like the V4L2 VB2 code.

Solves this sparce warning:
drivers/media/platform/exynos-gsc/gsc-m2m.c:716:24: warning: incorrect type in return expression (different base types)
drivers/media/platform/exynos-gsc/gsc-m2m.c:716:24: expected restricted __poll_t
drivers/media/platform/exynos-gsc/gsc-m2m.c:716:24: got int

Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

parent 484f9b37

drivers/media/platform/exynos-gsc/gsc-m2m.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -713,7 +713,7 @@ static __poll_t gsc_m2m_poll(struct file *file,
		__poll_t ret;

		if (mutex_lock_interruptible(&gsc->lock))
		return -ERESTARTSYS;
		return EPOLLERR;

		ret = v4l2_m2m_poll(file, ctx->m2m_ctx, wait);
		mutex_unlock(&gsc->lock);

Admin message