Commit 5418c692 authored Jun 18, 2005 by Jesper Juhl Committed by David S. Miller Jun 18, 2005

[IPV4]: [1/4] signed vs unsigned cleanup in net/ipv4/raw.c

This patch silences these two gcc -W warnings in net/ipv4/raw.c :

net/ipv4/raw.c:517: warning: signed and unsigned type in conditional expression
net/ipv4/raw.c:613: warning: signed and unsigned type in conditional expression

It doesn't change the behaviour of the code, simply writes the conditional
expression with plain 'if()' syntax instead of '? :' , but since this
breaks it into sepperate statements gcc no longer complains about having
both a signed and unsigned value in the same conditional expression.

Signed-off-by: David S. Miller <davem@davemloft.net>

parent 94df109a

net/ipv4/raw.c

+8 −2

Original line number	Diff line number	Diff line
		@@ -514,7 +514,10 @@ done:
		kfree(ipc.opt);
		ip_rt_put(rt);

		out: return err < 0 ? err : len;
		out:
		if (err < 0)
		return err;
		return len;

		do_confirm:
		dst_confirm(&rt->u.dst);
		@@ -610,7 +613,10 @@ static int raw_recvmsg(struct kiocb iocb, struct sock sk, struct msghdr *msg,
		copied = skb->len;
		done:
		skb_free_datagram(sk, skb);
		out: return err ? err : copied;
		out:
		if (err)
		return err;
		return copied;
		}

		static int raw_init(struct sock *sk)

Admin message