Commit 541768b0 authored Jun 29, 2017 by Vignesh R Committed by Felipe Balbi Jul 17, 2017

usb: dwc3: core: Call dwc3_core_get_phy() before initializing phys



commit f54edb53 ("usb: dwc3: core: initialize ULPI before trying to
get the PHY") moved call to dwc3_core_get_phy() from dwc3_probe() to
dwc3_core_init() after dwc3_core_soft_reset(). But
dwc3_core_soft_reset() calls phy_init(), therefore dwc3_core_get_phy()
needs to be called before dwc3_core_soft_reset().

Fix this by moving call to dwc3_core_get_phy() before
dwc3_core_soft_reset().

This fixes the following abort seen on DRA7xx platforms
[   24.769118] usb usb2: SerialNumber: xhci-hcd.1.auto
[   24.781144] hub 2-0:1.0: USB hub found
[   24.787836] hub 2-0:1.0: 1 port detected
[   24.809939] Unhandled fault: imprecise external abort (0x1406) at 0x00000000

Reported-by: Carlos Hernandez <ceh@ti.com>
Signed-off-by: Vignesh R <vigneshr@ti.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>

parent 5771a8c0

drivers/usb/dwc3/core.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -766,15 +766,15 @@ static int dwc3_core_init(struct dwc3 *dwc)
		dwc->maximum_speed = USB_SPEED_HIGH;
		}

		ret = dwc3_core_soft_reset(dwc);
		ret = dwc3_core_get_phy(dwc);
		if (ret)
		goto err0;

		ret = dwc3_phy_setup(dwc);
		ret = dwc3_core_soft_reset(dwc);
		if (ret)
		goto err0;

		ret = dwc3_core_get_phy(dwc);
		ret = dwc3_phy_setup(dwc);
		if (ret)
		goto err0;

Admin message