Commit 5405d005 authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

posix-cpu-timers: Remove pointless return value check 



set_process_cpu_timer() checks already whether the clock id is valid. No
point in checking the return value of the sample function. That allows to
simplify the sample function later.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Reviewed-by: default avatarFrederic Weisbecker <frederic@kernel.org>
Link: https://lkml.kernel.org/r/20190821192920.339725769@linutronix.de
parent da020ce4

kernel/time/posix-cpu-timers.c

+2 −3
Original line number Diff line number Diff line
@@ -1190,14 +1190,13 @@ void set_process_cpu_timer(struct task_struct *tsk, unsigned int clock_idx, 
			   u64 *newval, u64 *oldval)

{

	u64 now;

	int ret;



	if (WARN_ON_ONCE(clock_idx >= CPUCLOCK_SCHED))

		return;



	ret = cpu_clock_sample_group(clock_idx, tsk, &now, true);

	cpu_clock_sample_group(clock_idx, tsk, &now, true);



	if (oldval && ret != -EINVAL) {

	if (oldval) {

		/*

		 * We are setting itimer. The *oldval is absolute and we update

		 * it to be relative, *newval argument is relative and we update

CRA Git | Maintained and supported by SUSTech CRA and CCSE