Commit 54027a49 authored Jan 23, 2020 by Darrick J. Wong

xfs: fix uninitialized variable in xfs_attr3_leaf_inactive



Dan Carpenter pointed out that error is uninitialized.  While there
never should be an attr leaf block with zero entries, let's not leave
that logic bomb there.

Fixes: 0bb9d159 ("xfs: streamline xfs_attr3_leaf_inactive")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Allison Collins <allison.henderson@oracle.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>

parent aa124436

fs/xfs/xfs_attr_inactive.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -89,7 +89,7 @@ xfs_attr3_leaf_inactive(
		struct xfs_attr_leafblock *leaf = bp->b_addr;
		struct xfs_attr_leaf_entry *entry;
		struct xfs_attr_leaf_name_remote *name_rmt;
		int error;
		int error = 0;
		int i;

		xfs_attr3_leaf_hdr_from_disk(mp->m_attr_geo, &ichdr, leaf);

Admin message