Commit 53e9d838 authored Nov 26, 2018 by Dan Carpenter Committed by Mauro Carvalho Chehab Dec 03, 2018

media: cedrus: Fix a NULL vs IS_ERR() check



The devm_ioremap_resource() function doesn't return NULL pointers, it
returns error pointers.

Fixes: 50e76151 ("media: platform: Add Cedrus VPU decoder driver")

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

parent 230bce55

drivers/staging/media/sunxi/cedrus/cedrus_hw.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -255,10 +255,10 @@ int cedrus_hw_probe(struct cedrus_dev *dev)

		res = platform_get_resource(dev->pdev, IORESOURCE_MEM, 0);
		dev->base = devm_ioremap_resource(dev->dev, res);
		if (!dev->base) {
		if (IS_ERR(dev->base)) {
		v4l2_err(&dev->v4l2_dev, "Failed to map registers\n");

		ret = -ENOMEM;
		ret = PTR_ERR(dev->base);
		goto err_sram;
		}

Admin message