Commit 53d84e00 authored by Paul E. McKenney's avatar Paul E. McKenney
Browse files

rcu: permit suppressing current grace period's CPU stall warnings 



When using a kernel debugger, a long sojourn in the debugger can get
you lots of RCU CPU stall warnings once you resume.  This might not be
helpful, especially if you are using the system console.  This patch
therefore allows RCU CPU stall warnings to be suppressed, but only for
the duration of the current set of grace periods.

This differs from Jason's original patch in that it adds support for
tiny RCU and preemptible RCU, and uses a slightly different method for
suppressing the RCU CPU stall warning messages.

Signed-off-by: default avatarJason Wessel <jason.wessel@windriver.com>
Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Tested-by: default avatarJason Wessel <jason.wessel@windriver.com>
parent 8cdd32a9

include/linux/rcutiny.h

+4 −0
Original line number Diff line number Diff line
@@ -178,6 +178,10 @@ static inline void rcu_sched_force_quiescent_state(void) 
{

}



static inline void rcu_cpu_stall_reset(void)

{

}



#ifdef CONFIG_DEBUG_LOCK_ALLOC



extern int rcu_scheduler_active __read_mostly;

include/linux/rcutree.h

+1 −0
Original line number Diff line number Diff line
@@ -36,6 +36,7 @@ extern void rcu_sched_qs(int cpu); 
extern void rcu_bh_qs(int cpu);

extern void rcu_note_context_switch(int cpu);

extern int rcu_needs_cpu(int cpu);

extern void rcu_cpu_stall_reset(void);



#ifdef CONFIG_TREE_PREEMPT_RCU

kernel/rcutree.c

+20 −0
Original line number Diff line number Diff line
@@ -565,6 +565,22 @@ static int rcu_panic(struct notifier_block *this, unsigned long ev, void *ptr) 
	return NOTIFY_DONE;

}



/**

 * rcu_cpu_stall_reset - prevent further stall warnings in current grace period

 *

 * Set the stall-warning timeout way off into the future, thus preventing

 * any RCU CPU stall-warning messages from appearing in the current set of

 * RCU grace periods.

 *

 * The caller must disable hard irqs.

 */

void rcu_cpu_stall_reset(void)

{

	rcu_sched_state.jiffies_stall = jiffies + ULONG_MAX / 2;

	rcu_bh_state.jiffies_stall = jiffies + ULONG_MAX / 2;

	rcu_preempt_stall_reset();

}



static struct notifier_block rcu_panic_block = {

	.notifier_call = rcu_panic,

};
@@ -584,6 +600,10 @@ static void check_cpu_stall(struct rcu_state *rsp, struct rcu_data *rdp) 
{

}



void rcu_cpu_stall_reset(void)

{

}



static void __init check_cpu_stall_init(void)

{

}

kernel/rcutree.h

+1 −0
Original line number Diff line number Diff line
@@ -372,6 +372,7 @@ static void rcu_report_unblock_qs_rnp(struct rcu_node *rnp, 
#ifdef CONFIG_RCU_CPU_STALL_DETECTOR

static void rcu_print_detail_task_stall(struct rcu_state *rsp);

static void rcu_print_task_stall(struct rcu_node *rnp);

static void rcu_preempt_stall_reset(void);

#endif /* #ifdef CONFIG_RCU_CPU_STALL_DETECTOR */

static void rcu_preempt_check_blocked_tasks(struct rcu_node *rnp);

#ifdef CONFIG_HOTPLUG_CPU

kernel/rcutree_plugin.h

+18 −0
Original line number Diff line number Diff line
@@ -417,6 +417,16 @@ static void rcu_print_task_stall(struct rcu_node *rnp) 
	}

}



/*

 * Suppress preemptible RCU's CPU stall warnings by pushing the

 * time of the next stall-warning message comfortably far into the

 * future.

 */

static void rcu_preempt_stall_reset(void)

{

	rcu_preempt_state.jiffies_stall = jiffies + ULONG_MAX / 2;

}



#endif /* #ifdef CONFIG_RCU_CPU_STALL_DETECTOR */



/*
@@ -867,6 +877,14 @@ static void rcu_print_task_stall(struct rcu_node *rnp) 
{

}



/*

 * Because preemptible RCU does not exist, there is no need to suppress

 * its CPU stall warnings.

 */

static void rcu_preempt_stall_reset(void)

{

}



#endif /* #ifdef CONFIG_RCU_CPU_STALL_DETECTOR */



/*

CRA Git | Maintained and supported by SUSTech CRA and CCSE