Commit 53b4b2ae authored Nov 05, 2019 by Dmitry Osipenko Committed by Chanwoo Choi Nov 06, 2019

PM / devfreq: tegra30: Fix integer overflow on CPU's freq max out



There is another kHz-conversion bug in the code, resulting in integer
overflow. Although, this time the resulting value is 4294966296 and it's
close to ULONG_MAX, which is okay in this case.

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Tested-by: Peter Geis <pgwipeout@gmail.com>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>

parent e7955a34

drivers/devfreq/tegra30-devfreq.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -69,6 +69,8 @@

		#define KHZ 1000

		#define KHZ_MAX (ULONG_MAX / KHZ)

		/* Assume that the bus is saturated if the utilization is 25% */
		#define BUS_SATURATION_RATIO 25

		@@ -170,7 +172,7 @@ struct tegra_actmon_emc_ratio {
		};

		static struct tegra_actmon_emc_ratio actmon_emc_ratios[] = {
		{ 1400000, ULONG_MAX },
		{ 1400000, KHZ_MAX },
		{ 1200000, 750000 },
		{ 1100000, 600000 },
		{ 1000000, 500000 },

Admin message