Commit 53896798 authored Jan 14, 2017 by Baolin Wang Committed by Felipe Balbi Jan 24, 2017

usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

When handing the SETUP packet by composite_setup(), we will release the
dwc->lock. If we get the 'USB_GADGET_DELAYED_STATUS' result from setup
function, which means we need to delay handling the STATUS phase.

But during the lock release period, maybe the request for handling delay
STATUS phase has been queued into list before we set 'dwc->delayed_status'
flag or entering 'EP0_STATUS_PHASE' phase, then we will miss the chance
to handle the STATUS phase. Thus we should check if the request for delay
STATUS phase has been enqueued when entering 'EP0_STATUS_PHASE' phase in
dwc3_ep0_xfernotready(), if so, we should handle it.

Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>

parent 746c9085

drivers/usb/dwc3/ep0.c

+14 −0

Original line number	Diff line number	Diff line
		@@ -1123,7 +1123,21 @@ static void dwc3_ep0_xfernotready(struct dwc3 *dwc,
		dwc->ep0state = EP0_STATUS_PHASE;

		if (dwc->delayed_status) {
		struct dwc3_ep *dep = dwc->eps[0];

		WARN_ON_ONCE(event->endpoint_number != 1);
		/*
		* We should handle the delay STATUS phase here if the
		* request for handling delay STATUS has been queued
		* into the list.
		*/
		if (!list_empty(&dep->pending_list)) {
		dwc->delayed_status = false;
		usb_gadget_set_state(&dwc->gadget,
		USB_STATE_CONFIGURED);
		dwc3_ep0_do_control_status(dwc, event);
		}

		return;
		}

Admin message