Commit 5379e4dd authored by Thomas Hellstrom's avatar Thomas Hellstrom
Browse files

mm, drm/ttm: Fix vm page protection handling 



TTM graphics buffer objects may, transparently to user-space,  move
between IO and system memory. When that happens, all PTEs pointing to the
old location are zapped before the move and then faulted in again if
needed. When that happens, the page protection caching mode- and
encryption bits may change and be different from those of
struct vm_area_struct::vm_page_prot.

We were using an ugly hack to set the page protection correctly.
Fix that and instead export and use vmf_insert_mixed_prot() or use
vmf_insert_pfn_prot().
Also get the default page protection from
struct vm_area_struct::vm_page_prot rather than using vm_get_page_prot().
This way we catch modifications done by the vm system for drivers that
want write-notification.

Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Ralph Campbell <rcampbell@nvidia.com>
Cc: "Jérôme Glisse" <jglisse@redhat.com>
Cc: "Christian König" <christian.koenig@amd.com>
Signed-off-by: default avatarThomas Hellstrom <thellstrom@vmware.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Acked-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 574c5b3d

drivers/gpu/drm/ttm/ttm_bo_vm.c

+15 −7
Original line number Diff line number Diff line
@@ -179,7 +179,6 @@ vm_fault_t ttm_bo_vm_fault_reserved(struct vm_fault *vmf, 
				    pgoff_t num_prefault)

{

	struct vm_area_struct *vma = vmf->vma;

	struct vm_area_struct cvma = *vma;

	struct ttm_buffer_object *bo = vma->vm_private_data;

	struct ttm_bo_device *bdev = bo->bdev;

	unsigned long page_offset;
@@ -250,7 +249,7 @@ vm_fault_t ttm_bo_vm_fault_reserved(struct vm_fault *vmf, 
		goto out_io_unlock;

	}



	cvma.vm_page_prot = ttm_io_prot(bo->mem.placement, prot);

	prot = ttm_io_prot(bo->mem.placement, prot);

	if (!bo->mem.bus.is_iomem) {

		struct ttm_operation_ctx ctx = {

			.interruptible = false,
@@ -266,7 +265,7 @@ vm_fault_t ttm_bo_vm_fault_reserved(struct vm_fault *vmf, 
		}

	} else {

		/* Iomem should not be marked encrypted */

		cvma.vm_page_prot = pgprot_decrypted(cvma.vm_page_prot);

		prot = pgprot_decrypted(prot);

	}



	/*
@@ -289,11 +288,20 @@ vm_fault_t ttm_bo_vm_fault_reserved(struct vm_fault *vmf, 
			pfn = page_to_pfn(page);

		}



		/*

		 * Note that the value of @prot at this point may differ from

		 * the value of @vma->vm_page_prot in the caching- and

		 * encryption bits. This is because the exact location of the

		 * data may not be known at mmap() time and may also change

		 * at arbitrary times while the data is mmap'ed.

		 * See vmf_insert_mixed_prot() for a discussion.

		 */

		if (vma->vm_flags & VM_MIXEDMAP)

			ret = vmf_insert_mixed(&cvma, address,

					__pfn_to_pfn_t(pfn, PFN_DEV));

			ret = vmf_insert_mixed_prot(vma, address,

						    __pfn_to_pfn_t(pfn, PFN_DEV),

						    prot);

		else

			ret = vmf_insert_pfn(&cvma, address, pfn);

			ret = vmf_insert_pfn_prot(vma, address, pfn, prot);



		/* Never error on prefaulted PTEs */

		if (unlikely((ret & VM_FAULT_ERROR))) {
@@ -325,7 +333,7 @@ vm_fault_t ttm_bo_vm_fault(struct vm_fault *vmf) 
	if (ret)

		return ret;



	prot = vm_get_page_prot(vma->vm_flags);

	prot = vma->vm_page_prot;

	ret = ttm_bo_vm_fault_reserved(vmf, prot, TTM_BO_VM_NUM_PREFAULT);

	if (ret == VM_FAULT_RETRY && !(vmf->flags & FAULT_FLAG_RETRY_NOWAIT))

		return ret;

mm/memory.c

+1 −0
Original line number Diff line number Diff line
@@ -1816,6 +1816,7 @@ vm_fault_t vmf_insert_mixed_prot(struct vm_area_struct *vma, unsigned long addr, 
{

	return __vm_insert_mixed(vma, addr, pfn, pgprot, false);

}

EXPORT_SYMBOL(vmf_insert_mixed_prot);



vm_fault_t vmf_insert_mixed(struct vm_area_struct *vma, unsigned long addr,

		pfn_t pfn)

CRA Git | Maintained and supported by SUSTech CRA and CCSE