Commit 5352ae63 authored by Jason Wessel's avatar Jason Wessel Committed by Ingo Molnar
Browse files

perf, hw_breakpoint, kgdb: Do not take mutex for kernel debugger 



This patch fixes the regression in functionality where the
kernel debugger and the perf API do not nicely share hw
breakpoint reservations.

The kernel debugger cannot use any mutex_lock() calls because it
can start the kernel running from an invalid context.

A mutex free version of the reservation API needed to get
created for the kernel debugger to safely update hw breakpoint
reservations.

The possibility for a breakpoint reservation to be concurrently
processed at the time that kgdb interrupts the system is
improbable. Should this corner case occur the end user is
warned, and the kernel debugger will prohibit updating the
hardware breakpoint reservations.

Any time the kernel debugger reserves a hardware breakpoint it
will be a system wide reservation.

Signed-off-by: default avatarJason Wessel <jason.wessel@windriver.com>
Acked-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
Cc: kgdb-bugreport@lists.sourceforge.net
Cc: K.Prasad <prasad@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: torvalds@linux-foundation.org
LKML-Reference: <1264719883-7285-3-git-send-email-jason.wessel@windriver.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent cc096749

arch/x86/kernel/kgdb.c

+51 −0
Original line number Diff line number Diff line
@@ -239,6 +239,49 @@ static void kgdb_correct_hw_break(void) 
	hw_breakpoint_restore();

}



static int hw_break_reserve_slot(int breakno)

{

	int cpu;

	int cnt = 0;

	struct perf_event **pevent;



	for_each_online_cpu(cpu) {

		cnt++;

		pevent = per_cpu_ptr(breakinfo[breakno].pev, cpu);

		if (dbg_reserve_bp_slot(*pevent))

			goto fail;

	}



	return 0;



fail:

	for_each_online_cpu(cpu) {

		cnt--;

		if (!cnt)

			break;

		pevent = per_cpu_ptr(breakinfo[breakno].pev, cpu);

		dbg_release_bp_slot(*pevent);

	}

	return -1;

}



static int hw_break_release_slot(int breakno)

{

	struct perf_event **pevent;

	int cpu;



	for_each_online_cpu(cpu) {

		pevent = per_cpu_ptr(breakinfo[breakno].pev, cpu);

		if (dbg_release_bp_slot(*pevent))

			/*

			 * The debugger is responisble for handing the retry on

			 * remove failure.

			 */

			return -1;

	}

	return 0;

}



static int

kgdb_remove_hw_break(unsigned long addr, int len, enum kgdb_bptype bptype)

{
@@ -250,6 +293,10 @@ kgdb_remove_hw_break(unsigned long addr, int len, enum kgdb_bptype bptype) 
	if (i == 4)

		return -1;



	if (hw_break_release_slot(i)) {

		printk(KERN_ERR "Cannot remove hw breakpoint at %lx\n", addr);

		return -1;

	}

	breakinfo[i].enabled = 0;



	return 0;
@@ -316,6 +363,10 @@ kgdb_set_hw_break(unsigned long addr, int len, enum kgdb_bptype bptype) 
		return -1;

	}

	breakinfo[i].addr = addr;

	if (hw_break_reserve_slot(i)) {

		breakinfo[i].addr = 0;

		return -1;

	}

	breakinfo[i].enabled = 1;



	return 0;

include/linux/hw_breakpoint.h

+2 −0
Original line number Diff line number Diff line
@@ -75,6 +75,8 @@ extern int __register_perf_hw_breakpoint(struct perf_event *bp); 
extern void unregister_hw_breakpoint(struct perf_event *bp);

extern void unregister_wide_hw_breakpoint(struct perf_event **cpu_events);



extern int dbg_reserve_bp_slot(struct perf_event *bp);

extern int dbg_release_bp_slot(struct perf_event *bp);

extern int reserve_bp_slot(struct perf_event *bp);

extern void release_bp_slot(struct perf_event *bp);

kernel/hw_breakpoint.c

+42 −10
Original line number Diff line number Diff line
@@ -243,38 +243,70 @@ static void toggle_bp_slot(struct perf_event *bp, bool enable) 
 *       ((per_cpu(nr_bp_flexible, *) > 1) + max(per_cpu(nr_cpu_bp_pinned, *))

 *            + max(per_cpu(nr_task_bp_pinned, *))) < HBP_NUM

 */

int reserve_bp_slot(struct perf_event *bp)

static int __reserve_bp_slot(struct perf_event *bp)

{

	struct bp_busy_slots slots = {0};

	int ret = 0;



	mutex_lock(&nr_bp_mutex);



	fetch_bp_busy_slots(&slots, bp);



	/* Flexible counters need to keep at least one slot */

	if (slots.pinned + (!!slots.flexible) == HBP_NUM) {

		ret = -ENOSPC;

		goto end;

	}

	if (slots.pinned + (!!slots.flexible) == HBP_NUM)

		return -ENOSPC;



	toggle_bp_slot(bp, true);



end:

	return 0;

}



int reserve_bp_slot(struct perf_event *bp)

{

	int ret;



	mutex_lock(&nr_bp_mutex);



	ret = __reserve_bp_slot(bp);



	mutex_unlock(&nr_bp_mutex);



	return ret;

}



static void __release_bp_slot(struct perf_event *bp)

{

	toggle_bp_slot(bp, false);

}



void release_bp_slot(struct perf_event *bp)

{

	mutex_lock(&nr_bp_mutex);



	toggle_bp_slot(bp, false);

	__release_bp_slot(bp);



	mutex_unlock(&nr_bp_mutex);

}



/*

 * Allow the kernel debugger to reserve breakpoint slots without

 * taking a lock using the dbg_* variant of for the reserve and

 * release breakpoint slots.

 */

int dbg_reserve_bp_slot(struct perf_event *bp)

{

	if (mutex_is_locked(&nr_bp_mutex))

		return -1;



	return __reserve_bp_slot(bp);

}



int dbg_release_bp_slot(struct perf_event *bp)

{

	if (mutex_is_locked(&nr_bp_mutex))

		return -1;



	__release_bp_slot(bp);



	return 0;

}



int register_perf_hw_breakpoint(struct perf_event *bp)

{

CRA Git | Maintained and supported by SUSTech CRA and CCSE