Commit 5349d3d8 authored Aug 06, 2011 by Thomas Meyer Committed by Greg Kroah-Hartman Aug 23, 2011

staging: brcm80211: use kzalloc()

Use kzalloc rather than kmalloc followed by memset with 0

This considers some simple cases that are common and easy to validate
Note in particular that there are no ...s in the rule, so all of the
matched code has to be contiguous

The semantic patch that makes this output is available
in scripts/coccinelle/api/alloc/kzalloc-simple.cocci.

More information about semantic patching is available at
http://coccinelle.lip6.fr/



Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Acked-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 5a84d6ad

drivers/staging/brcm80211/brcmfmac/dhd_sdio.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -5644,14 +5644,12 @@ brcmf_sdbrcm_chip_attach(struct brcmf_bus *bus, u32 regs)
		BRCMF_TRACE(("%s: Enter\n", __func__));

		/* alloc chip_info_t */
		ci = kmalloc(sizeof(struct chip_info), GFP_ATOMIC);
		ci = kzalloc(sizeof(struct chip_info), GFP_ATOMIC);
		if (NULL == ci) {
		BRCMF_ERROR(("%s: malloc failed!\n", __func__));
		return -ENOMEM;
		}

		memset((unsigned char *)ci, 0, sizeof(struct chip_info));

		/* bus/core/clk setup for register access */
		/* Try forcing SDIO core to do ALPAvail request only */
		clkset = SBSDIO_FORCE_HW_CLKREQ_OFF \| SBSDIO_ALP_AVAIL_REQ;

Admin message