Commit 53466710 authored Dec 06, 2011 by Eric Sandeen Committed by David Woodhouse Jan 09, 2012

jffs2: fix up error handling for insert_inode_locked



after 250df6ed
(fs: protect inode->i_state with inode->i_lock), insert_inode_locked()
no longer returns the inode with I_NEW set on failure.  However,
the error handler still calls unlock_new_inode() on failure,
which does a WARN_ON if I_NEW is not set, so any failure spews
a lot of warnings.

We can just drop the unlock_new_inode() if insert_inode_locked()
fails here.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@linux.intel.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>

parent fa3ae714

fs/jffs2/fs.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -466,7 +466,6 @@ struct inode jffs2_new_inode (struct inode dir_i, umode_t mode, struct jffs2_r

		if (insert_inode_locked(inode) < 0) {
		make_bad_inode(inode);
		unlock_new_inode(inode);
		iput(inode);
		return ERR_PTR(-EINVAL);
		}

Admin message