Commit 533852d7 authored Sep 21, 2020 by Krzysztof Kozlowski Committed by Stephen Boyd Sep 22, 2020

clk: s2mps11: initialize driver via module_platform_driver



The driver was using subsys_initcall() because in old times deferred
probe was not supported everywhere and specific ordering was needed.
Since probe deferral works fine and specific ordering is discouraged
(hides dependencies between drivers and couples their boot order), the
driver can be converted to regular module_platform_driver.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20200921203558.19554-1-krzk@kernel.org


Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

parent 553be99d

drivers/clk/clk-s2mps11.c

+1 −12

Original line number	Diff line number	Diff line
		@@ -267,18 +267,7 @@ static struct platform_driver s2mps11_clk_driver = {
		.remove = s2mps11_clk_remove,
		.id_table = s2mps11_clk_id,
		};

		static int __init s2mps11_clk_init(void)
		{
		return platform_driver_register(&s2mps11_clk_driver);
		}
		subsys_initcall(s2mps11_clk_init);

		static void __exit s2mps11_clk_cleanup(void)
		{
		platform_driver_unregister(&s2mps11_clk_driver);
		}
		module_exit(s2mps11_clk_cleanup);
		module_platform_driver(s2mps11_clk_driver);

		MODULE_DESCRIPTION("S2MPS11 Clock Driver");
		MODULE_AUTHOR("Yadwinder Singh Brar <yadi.brar@samsung.com>");

Admin message