Commit 5334b342 authored by Hans de Goede's avatar Hans de Goede Committed by Mauro Carvalho Chehab
Browse files

media: gspca: Stop using GFP_DMA for buffers for USB bulk transfers 



The recent "x86 ZONE_DMA love" discussion at LSF/MM pointed out that some
gspca sub-drivvers are using GFP_DMA to allocate buffers which are used
for USB bulk transfers, there is absolutely no need for this, drop it.

Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 6159e12e

drivers/media/usb/gspca/jl2005bcd.c

+1 −1
Original line number Diff line number Diff line
@@ -321,7 +321,7 @@ static void jl2005c_dostream(struct work_struct *work) 
	int ret;

	u8 *buffer;



	buffer = kmalloc(JL2005C_MAX_TRANSFER, GFP_KERNEL | GFP_DMA);

	buffer = kmalloc(JL2005C_MAX_TRANSFER, GFP_KERNEL);

	if (!buffer) {

		pr_err("Couldn't allocate USB buffer\n");

		goto quit_stream;

drivers/media/usb/gspca/sq905.c

+1 −1
Original line number Diff line number Diff line
@@ -217,7 +217,7 @@ static void sq905_dostream(struct work_struct *work) 
	u8 *data;

	u8 *buffer;



	buffer = kmalloc(SQ905_MAX_TRANSFER, GFP_KERNEL | GFP_DMA);

	buffer = kmalloc(SQ905_MAX_TRANSFER, GFP_KERNEL);

	if (!buffer) {

		pr_err("Couldn't allocate USB buffer\n");

		goto quit_stream;

drivers/media/usb/gspca/sq905c.c

+1 −1
Original line number Diff line number Diff line
@@ -138,7 +138,7 @@ static void sq905c_dostream(struct work_struct *work) 
	int ret;

	u8 *buffer;



	buffer = kmalloc(SQ905C_MAX_TRANSFER, GFP_KERNEL | GFP_DMA);

	buffer = kmalloc(SQ905C_MAX_TRANSFER, GFP_KERNEL);

	if (!buffer) {

		pr_err("Couldn't allocate USB buffer\n");

		goto quit_stream;

drivers/media/usb/gspca/vicam.c

+1 −1
Original line number Diff line number Diff line
@@ -182,7 +182,7 @@ static void vicam_dostream(struct work_struct *work) 


	frame_sz = gspca_dev->cam.cam_mode[gspca_dev->curr_mode].sizeimage +

		   HEADER_SIZE;

	buffer = kmalloc(frame_sz, GFP_KERNEL | GFP_DMA);

	buffer = kmalloc(frame_sz, GFP_KERNEL);

	if (!buffer) {

		pr_err("Couldn't allocate USB buffer\n");

		goto exit;

CRA Git | Maintained and supported by SUSTech CRA and CCSE