Commit 53168215 authored by Johannes Berg's avatar Johannes Berg
Browse files

mac80211: fix VLAN handling with TXQs 



With TXQs, the AP_VLAN interfaces are resolved to their owner AP
interface when enqueuing the frame, which makes sense since the
frame really goes out on that as far as the driver is concerned.

However, this introduces a problem: frames to be encrypted with
a VLAN-specific GTK will now be encrypted with the AP GTK, since
the information about which virtual interface to use to select
the key is taken from the TXQ.

Fix this by preserving info->control.vif and using that in the
dequeue function. This now requires doing the driver-mapping
in the dequeue as well.

Since there's no way to filter the frames that are sitting on a
TXQ, drop all frames, which may affect other interfaces, when an
AP_VLAN is removed.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 7a7d3e4c

include/net/mac80211.h

+2 −13
Original line number Diff line number Diff line
@@ -918,22 +918,11 @@ struct ieee80211_tx_info { 
				/* only needed before rate control */

				unsigned long jiffies;

			};

			/* NB: vif can be NULL for injected frames */

			union {

			/* NB: vif can be NULL for injected frames */

			struct ieee80211_vif *vif;



				/* When packets are enqueued on txq it's easy

				 * to re-construct the vif pointer. There's no

				 * more space in tx_info so it can be used to

				 * store the necessary enqueue time for packet

				 * sojourn time computation.

				 */

				codel_time_t enqueue_time;

			};

			struct ieee80211_key_conf *hw_key;

			u32 flags;

			/* 4 bytes free */

			codel_time_t enqueue_time;

		} control;

		struct {

			u64 cookie;

net/mac80211/iface.c

+15 −2
Original line number Diff line number Diff line
@@ -792,6 +792,7 @@ static int ieee80211_open(struct net_device *dev) 
static void ieee80211_do_stop(struct ieee80211_sub_if_data *sdata,

			      bool going_down)

{

	struct ieee80211_sub_if_data *txq_sdata = sdata;

	struct ieee80211_local *local = sdata->local;

	struct fq *fq = &local->fq;

	unsigned long flags;
@@ -937,6 +938,9 @@ static void ieee80211_do_stop(struct ieee80211_sub_if_data *sdata, 


	switch (sdata->vif.type) {

	case NL80211_IFTYPE_AP_VLAN:

		txq_sdata = container_of(sdata->bss,

					 struct ieee80211_sub_if_data, u.ap);



		mutex_lock(&local->mtx);

		list_del(&sdata->u.vlan.list);

		mutex_unlock(&local->mtx);
@@ -1007,8 +1011,17 @@ static void ieee80211_do_stop(struct ieee80211_sub_if_data *sdata, 
	}

	spin_unlock_irqrestore(&local->queue_stop_reason_lock, flags);



	if (sdata->vif.txq) {

		struct txq_info *txqi = to_txq_info(sdata->vif.txq);

	if (txq_sdata->vif.txq) {

		struct txq_info *txqi = to_txq_info(txq_sdata->vif.txq);



		/*

		 * FIXME FIXME

		 *

		 * We really shouldn't purge the *entire* txqi since that

		 * contains frames for the other AP_VLANs (and possibly

		 * the AP itself) as well, but there's no API in FQ now

		 * to be able to filter.

		 */



		spin_lock_bh(&fq->lock);

		ieee80211_txq_purge(local, txqi);

net/mac80211/tx.c

+29 −7
Original line number Diff line number Diff line
@@ -1276,11 +1276,6 @@ static void ieee80211_set_skb_enqueue_time(struct sk_buff *skb) 
	IEEE80211_SKB_CB(skb)->control.enqueue_time = codel_get_time();

}



static void ieee80211_set_skb_vif(struct sk_buff *skb, struct txq_info *txqi)

{

	IEEE80211_SKB_CB(skb)->control.vif = txqi->txq.vif;

}



static u32 codel_skb_len_func(const struct sk_buff *skb)

{

	return skb->len;
@@ -3414,6 +3409,7 @@ struct sk_buff *ieee80211_tx_dequeue(struct ieee80211_hw *hw, 
	struct ieee80211_tx_info *info;

	struct ieee80211_tx_data tx;

	ieee80211_tx_result r;

	struct ieee80211_vif *vif;



	spin_lock_bh(&fq->lock);
@@ -3430,8 +3426,6 @@ begin: 
	if (!skb)

		goto out;



	ieee80211_set_skb_vif(skb, txqi);



	hdr = (struct ieee80211_hdr *)skb->data;

	info = IEEE80211_SKB_CB(skb);
@@ -3488,6 +3482,34 @@ begin: 
		}

	}



	switch (tx.sdata->vif.type) {

	case NL80211_IFTYPE_MONITOR:

		if (tx.sdata->u.mntr.flags & MONITOR_FLAG_ACTIVE) {

			vif = &tx.sdata->vif;

			break;

		}

		tx.sdata = rcu_dereference(local->monitor_sdata);

		if (tx.sdata) {

			vif = &tx.sdata->vif;

			info->hw_queue =

				vif->hw_queue[skb_get_queue_mapping(skb)];

		} else if (ieee80211_hw_check(&local->hw, QUEUE_CONTROL)) {

			ieee80211_free_txskb(&local->hw, skb);

			goto begin;

		} else {

			vif = NULL;

		}

		break;

	case NL80211_IFTYPE_AP_VLAN:

		tx.sdata = container_of(tx.sdata->bss,

					struct ieee80211_sub_if_data, u.ap);

		/* fall through */

	default:

		vif = &tx.sdata->vif;

		break;

	}



	IEEE80211_SKB_CB(skb)->control.vif = vif;

out:

	spin_unlock_bh(&fq->lock);

CRA Git | Maintained and supported by SUSTech CRA and CCSE