HID: hyperv: NULL check before some freeing functions is not needed. (5313b2a5) · Commits · 戴 / test

Fix below warnings reported by coccicheck: drivers/hid/hid-hyperv.c:197:2-7: WARNING: NULL check before some freeing functions is not needed. drivers/hid/hid-hyperv.c:211:2-7: WARNING: NULL check before some freeing functions is not needed. Signed-off-by:

Lucas Tanure <tanure@linux.com> Reviewed-by:

Michael Kelley <mikelley@microsoft.com> Reviewed-by:

Wei Liu <wei.liu@kernel.org> Acked-by:

Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by:

Wei Liu <wei.liu@kernel.org>

drivers/hid/hid-hyperv.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -193,7 +193,6 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev *input_device,
		goto cleanup;

		/* The pointer is not NULL when we resume from hibernation */
		if (input_device->hid_desc != NULL)
		kfree(input_device->hid_desc);
		input_device->hid_desc = kmemdup(desc, desc->bLength, GFP_ATOMIC);

		@@ -207,7 +206,6 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev *input_device,
		}

		/* The pointer is not NULL when we resume from hibernation */
		if (input_device->report_desc != NULL)
		kfree(input_device->report_desc);
		input_device->report_desc = kzalloc(input_device->report_desc_size,
		GFP_ATOMIC);

Admin message