Commit 5309665d authored Dec 06, 2010 by Christoph Lameter Committed by Tejun Heo Dec 17, 2010

fakekey: Simplify speakup_fake_key_pressed through this_cpu_ops

The whole function can be expressed as a simple this_cpu_read() operation.
The function overhead is now likely multiple times that of the single
instruction that is executed in it.

Sedat: fixed compile failure caused by an extra ')'.

Cc: William Hubbs <w.d.hubbs@gmail.com>
Cc: Sedat Dilek <sedat.dilek@gmail.com>
Acked-by: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Christoph Lameter <cl@linux.com>
Signed-off-by: Tejun Heo <tj@kernel.org>

parent b76834bc

drivers/staging/speakup/fakekey.c

+1 −6

Original line number	Diff line number	Diff line
		@@ -95,10 +95,5 @@ void speakup_fake_down_arrow(void)
		*/
		bool speakup_fake_key_pressed(void)
		{
		bool is_pressed;

		is_pressed = get_cpu_var(reporting_keystroke);
		put_cpu_var(reporting_keystroke);

		return is_pressed;
		return this_cpu_read(reporting_keystroke);
		}

Admin message