dmaengine: coh901318: convert tasklets to use new tasklet_setup() API (52fcf656) · Commits · 戴 / test

In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by:

Romain Perier <romain.perier@gmail.com> Signed-off-by:

Allen Pais <allen.lkml@gmail.com> Link: https://lore.kernel.org/r/20200831103542.305571-5-allen.lkml@gmail.com Signed-off-by:

Vinod Koul <vkoul@kernel.org>

drivers/dma/coh901318.c

+3 −4

Original line number	Diff line number	Diff line
		@@ -1868,9 +1868,9 @@ static struct coh901318_desc coh901318_queue_start(struct coh901318_chan cohc)
		* This tasklet is called from the interrupt handler to
		* handle each descriptor (DMA job) that is sent to a channel.
		*/
		static void dma_tasklet(unsigned long data)
		static void dma_tasklet(struct tasklet_struct *t)
		{
		struct coh901318_chan cohc = (struct coh901318_chan ) data;
		struct coh901318_chan *cohc = from_tasklet(cohc, t, tasklet);
		struct coh901318_desc *cohd_fin;
		unsigned long flags;
		struct dmaengine_desc_callback cb;
		@@ -2615,8 +2615,7 @@ static void coh901318_base_init(struct dma_device dma, const int pick_chans,
		INIT_LIST_HEAD(&cohc->active);
		INIT_LIST_HEAD(&cohc->queue);

		tasklet_init(&cohc->tasklet, dma_tasklet,
		(unsigned long) cohc);
		tasklet_setup(&cohc->tasklet, dma_tasklet);

		list_add_tail(&cohc->chan.device_node,
		&dma->channels);

Admin message