Commit 52ea27eb authored Mar 19, 2008 by Pavel Emelyanov Committed by Linus Torvalds Mar 19, 2008

memcgroup: fix check for thread being a group leader in memcgroup



The check t->pid == t->pid is not the blessed way to check whether a task is a
group leader.

This is not about the code beautifulness only, but about pid namespaces fixes
- both the tgid and the pid fields on the task_struct are (slowly :( )
becoming deprecated.

Besides, the thread_group_leader() macro makes only one dereference :)

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Paul Menage <menage@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 0cf01f66

mm/memcontrol.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1079,7 +1079,7 @@ static void mem_cgroup_move_task(struct cgroup_subsys *ss,
		* Only thread group leaders are allowed to migrate, the mm_struct is
		* in effect owned by the leader
		*/
		if (p->tgid != p->pid)
		if (!thread_group_leader(p))
		goto out;

		css_get(&mem->css);

Admin message