Commit 52e9d9f4 authored Nov 06, 2008 by Darren Jenkins Committed by Linus Torvalds Nov 06, 2008

fat: cleanup fat_parse_long() error handling



Coverity CID 2332 & 2333 RESOURCE_LEAK

In fat_search_long() if fat_parse_long() returns a -ve value we return
without first freeing unicode.  This patch free's them on this error path.

The above was false positive on current tree, but this change is more
clean, so apply as cleanup.

[hirofumi@mail.parknet.co.jp: fix coding style]
Signed-off-by: Darren Jenkins <darrenrjenkins@gmail.com>
Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 53472bc8

fs/fat/dir.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -373,9 +373,10 @@ parse_record:
		if (de->attr == ATTR_EXT) {
		int status = fat_parse_long(inode, &cpos, &bh, &de,
		&unicode, &nr_slots);
		if (status < 0)
		return status;
		else if (status == PARSE_INVALID)
		if (status < 0) {
		err = status;
		goto end_of_dir;
		} else if (status == PARSE_INVALID)
		continue;
		else if (status == PARSE_NOT_LONGNAME)
		goto parse_record;

Admin message