Commit 52e3632e authored by Roel Kluin's avatar Roel Kluin Committed by Linus Torvalds
Browse files

serial: fix off by one errors 



In zs_console_putchar() occurs:

	if (zs_transmit_drain(zport, irq))
		write_zsdata(zport, ch);

However if in zs_transmit_drain() no empty Tx Buffer occurs, limit reaches
-1 => true, and the write still occurs.

This patch changes postfix to prefix decrements in this and similar
functions to prevent similar mistakes in the future.  This decreases the
iterations with one but the chosen loop count was arbitrary anyway.

In sunhv limit reaches -1, not 0, so the test is off by one.

Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Acked-by: default avatarDavid S. Miller <davem@davemloft.net>
Acked-by: default avatarMaciej W. Rozycki <macro@linux-mips.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarAlan Cox <alan@linux.intel.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 607c268e

drivers/serial/sb1250-duart.c

+3 −3
Original line number Diff line number Diff line
@@ -204,7 +204,7 @@ static int sbd_receive_drain(struct sbd_port *sport) 
{

	int loops = 10000;



	while (sbd_receive_ready(sport) && loops--)

	while (sbd_receive_ready(sport) && --loops)

		read_sbdchn(sport, R_DUART_RX_HOLD);

	return loops;

}
@@ -218,7 +218,7 @@ static int __maybe_unused sbd_transmit_drain(struct sbd_port *sport) 
{

	int loops = 10000;



	while (!sbd_transmit_ready(sport) && loops--)

	while (!sbd_transmit_ready(sport) && --loops)

		udelay(2);

	return loops;

}
@@ -232,7 +232,7 @@ static int sbd_line_drain(struct sbd_port *sport) 
{

	int loops = 10000;



	while (!sbd_transmit_empty(sport) && loops--)

	while (!sbd_transmit_empty(sport) && --loops)

		udelay(2);

	return loops;

}

drivers/serial/sunhv.c

+1 −1
Original line number Diff line number Diff line
@@ -461,7 +461,7 @@ static void sunhv_console_write_paged(struct console *con, const char *s, unsign 
					break;

				udelay(1);

			}

			if (limit <= 0)

			if (limit < 0)

				break;

			page_bytes -= written;

			ra += written;

drivers/serial/zs.c

+3 −3
Original line number Diff line number Diff line
@@ -231,7 +231,7 @@ static int zs_receive_drain(struct zs_port *zport) 
{

	int loops = 10000;



	while ((read_zsreg(zport, R0) & Rx_CH_AV) && loops--)

	while ((read_zsreg(zport, R0) & Rx_CH_AV) && --loops)

		read_zsdata(zport);

	return loops;

}
@@ -241,7 +241,7 @@ static int zs_transmit_drain(struct zs_port *zport, int irq) 
	struct zs_scc *scc = zport->scc;

	int loops = 10000;



	while (!(read_zsreg(zport, R0) & Tx_BUF_EMP) && loops--) {

	while (!(read_zsreg(zport, R0) & Tx_BUF_EMP) && --loops) {

		zs_spin_unlock_cond_irq(&scc->zlock, irq);

		udelay(2);

		zs_spin_lock_cond_irq(&scc->zlock, irq);
@@ -254,7 +254,7 @@ static int zs_line_drain(struct zs_port *zport, int irq) 
	struct zs_scc *scc = zport->scc;

	int loops = 10000;



	while (!(read_zsreg(zport, R1) & ALL_SNT) && loops--) {

	while (!(read_zsreg(zport, R1) & ALL_SNT) && --loops) {

		zs_spin_unlock_cond_irq(&scc->zlock, irq);

		udelay(2);

		zs_spin_lock_cond_irq(&scc->zlock, irq);

CRA Git | Maintained and supported by SUSTech CRA and CCSE