Commit 52d210d9 authored Nov 07, 2015 by Geliang Tang Committed by Kees Cook Jun 02, 2016

pstore: drop file opened reference count



In ee1d2674 ("pstore: add pstore unregister") I added:
	.owner = THIS_MODULE,
in both pstore_fs_type and pstore_file_operations to increase a reference
count when pstore filesystem is mounted and pstore file is opened.

But, it's repetitive. There is no need to increase the opened reference
count. We only need to increase the mounted reference count. When a file
is opened, the filesystem can't be unmounted. Hence the pstore module
can't be unloaded either.

So I drop the opened reference count in this patch.

Fixes: ee1d2674 ("pstore: add pstore unregister")
Signed-off-by: Geliang Tang <geliangtang@163.com>
Signed-off-by: Kees Cook <keescook@chromium.org>

parent 8cfc8ddc

fs/pstore/inode.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -178,7 +178,6 @@ static loff_t pstore_file_llseek(struct file *file, loff_t off, int whence)
		}

		static const struct file_operations pstore_file_operations = {
		.owner = THIS_MODULE,
		.open = pstore_file_open,
		.read = pstore_file_read,
		.llseek = pstore_file_llseek,

Admin message