Commit 52d1e606 authored by Kirill Tkhai's avatar Kirill Tkhai Committed by Linus Torvalds
Browse files

mm: reuse only-pte-mapped KSM page in do_wp_page() 

Add an optimization for KSM pages almost in the same way that we have
for ordinary anonymous pages.  If there is a write fault in a page,
which is mapped to an only pte, and it is not related to swap cache; the
page may be reused without copying its content.

[ Note that we do not consider PageSwapCache() pages at least for now,
  since we don't want to complicate __get_ksm_page(), which has nice
  optimization based on this (for the migration case). Currenly it is
  spinning on PageSwapCache() pages, waiting for when they have
  unfreezed counters (i.e., for the migration finish). But we don't want
  to make it also spinning on swap cache pages, which we try to reuse,
  since there is not a very high probability to reuse them. So, for now
  we do not consider PageSwapCache() pages at all. ]

So in reuse_ksm_page() we check for 1) PageSwapCache() and 2)
page_stable_node(), to skip a page, which KSM is currently trying to
link to stable tree.  Then we do page_ref_freeze() to prohibit KSM to
merge one more page into the page, we are reusing.  After that, nobody
can refer to the reusing page: KSM skips !PageSwapCache() pages with
zero refcount; and the protection against of all other participants is
the same as for reused ordinary anon pages pte lock, page lock and
mmap_sem.

[akpm@linux-foundation.org: replace BUG_ON()s with WARN_ON()s]
Link: http://lkml.kernel.org/r/154471491016.31352.1168978849911555609.stgit@localhost.localdomain


Signed-off-by: default avatarKirill Tkhai <ktkhai@virtuozzo.com>
Reviewed-by: default avatarYang Shi <yang.shi@linux.alibaba.com>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Hugh Dickins <hughd@google.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Christian Koenig <christian.koenig@amd.com>
Cc: Claudio Imbrenda <imbrenda@linux.vnet.ibm.com>
Cc: Rik van Riel <riel@surriel.com>
Cc: Huang Ying <ying.huang@intel.com>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Kirill Tkhai <ktkhai@virtuozzo.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 7c9eefe8

include/linux/ksm.h

+7 −0
Original line number Diff line number Diff line
@@ -53,6 +53,8 @@ struct page *ksm_might_need_to_copy(struct page *page, 


void rmap_walk_ksm(struct page *page, struct rmap_walk_control *rwc);

void ksm_migrate_page(struct page *newpage, struct page *oldpage);

bool reuse_ksm_page(struct page *page,

			struct vm_area_struct *vma, unsigned long address);



#else  /* !CONFIG_KSM */
@@ -86,6 +88,11 @@ static inline void rmap_walk_ksm(struct page *page, 
static inline void ksm_migrate_page(struct page *newpage, struct page *oldpage)

{

}

static inline bool reuse_ksm_page(struct page *page,

			struct vm_area_struct *vma, unsigned long address)

{

	return false;

}

#endif /* CONFIG_MMU */

#endif /* !CONFIG_KSM */

mm/ksm.c

+28 −2
Original line number Diff line number Diff line
@@ -706,8 +706,9 @@ again: 
	 * case this node is no longer referenced, and should be freed;

	 * however, it might mean that the page is under page_ref_freeze().

	 * The __remove_mapping() case is easy, again the node is now stale;

	 * but if page is swapcache in migrate_page_move_mapping(), it might

	 * still be our page, in which case it's essential to keep the node.

	 * the same is in reuse_ksm_page() case; but if page is swapcache

	 * in migrate_page_move_mapping(), it might still be our page,

	 * in which case it's essential to keep the node.

	 */

	while (!get_page_unless_zero(page)) {

		/*
@@ -2642,6 +2643,31 @@ again: 
		goto again;

}



bool reuse_ksm_page(struct page *page,

		    struct vm_area_struct *vma,

		    unsigned long address)

{

#ifdef CONFIG_DEBUG_VM

	if (WARN_ON(is_zero_pfn(page_to_pfn(page))) ||

			WARN_ON(!page_mapped(page)) ||

			WARN_ON(!PageLocked(page))) {

		dump_page(page, "reuse_ksm_page");

		return false;

	}

#endif



	if (PageSwapCache(page) || !page_stable_node(page))

		return false;

	/* Prohibit parallel get_ksm_page() */

	if (!page_ref_freeze(page, 1))

		return false;



	page_move_anon_rmap(page, vma);

	page->index = linear_page_index(vma, address);

	page_ref_unfreeze(page, 1);



	return true;

}

#ifdef CONFIG_MIGRATION

void ksm_migrate_page(struct page *newpage, struct page *oldpage)

{

mm/memory.c

+14 −2
Original line number Diff line number Diff line
@@ -2505,8 +2505,11 @@ static vm_fault_t do_wp_page(struct vm_fault *vmf) 
	 * Take out anonymous pages first, anonymous shared vmas are

	 * not dirty accountable.

	 */

	if (PageAnon(vmf->page) && !PageKsm(vmf->page)) {

	if (PageAnon(vmf->page)) {

		int total_map_swapcount;

		if (PageKsm(vmf->page) && (PageSwapCache(vmf->page) ||

					   page_count(vmf->page) != 1))

			goto copy;

		if (!trylock_page(vmf->page)) {

			get_page(vmf->page);

			pte_unmap_unlock(vmf->pte, vmf->ptl);
@@ -2521,6 +2524,15 @@ static vm_fault_t do_wp_page(struct vm_fault *vmf) 
			}

			put_page(vmf->page);

		}

		if (PageKsm(vmf->page)) {

			bool reused = reuse_ksm_page(vmf->page, vmf->vma,

						     vmf->address);

			unlock_page(vmf->page);

			if (!reused)

				goto copy;

			wp_page_reuse(vmf);

			return VM_FAULT_WRITE;

		}

		if (reuse_swap_page(vmf->page, &total_map_swapcount)) {

			if (total_map_swapcount == 1) {

				/*
@@ -2541,7 +2553,7 @@ static vm_fault_t do_wp_page(struct vm_fault *vmf) 
					(VM_WRITE|VM_SHARED))) {

		return wp_page_shared(vmf);

	}



copy:

	/*

	 * Ok, we need to copy. Oh, well..

	 */

CRA Git | Maintained and supported by SUSTech CRA and CCSE