Commit 52baf987 authored Feb 20, 2019 by Jann Horn Committed by David S. Miller Feb 22, 2019

net: socket: add check for negative optlen in compat setsockopt



__sys_setsockopt() already checks for `optlen < 0`. Add an equivalent check
to the compat path for robustness. This has to be `> INT_MAX` instead of
`< 0` because the signedness of `optlen` is different here.

Signed-off-by: Jann Horn <jannh@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent f5b51fe8

net/compat.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -388,8 +388,12 @@ static int __compat_sys_setsockopt(int fd, int level, int optname,
		char __user *optval, unsigned int optlen)
		{
		int err;
		struct socket *sock = sockfd_lookup(fd, &err);
		struct socket *sock;

		if (optlen > INT_MAX)
		return -EINVAL;

		sock = sockfd_lookup(fd, &err);
		if (sock) {
		err = security_socket_setsockopt(sock, level, optname);
		if (err) {

Admin message