Commit 52a44f83 authored Mar 29, 2019 by Alexander Shishkin Committed by Ingo Molnar Apr 16, 2019

perf/core: Fix the address filtering fix



The following recent commit:

  c60f83b8 ("perf, pt, coresight: Fix address filters for vmas with non-zero offset")

changes the address filtering logic to communicate filter ranges to the PMU driver
via a single address range object, instead of having the driver do the final bit of
math.

That change forgets to take into account kernel filters, which are not calculated
the same way as DSO based filters.

Fix that by passing the kernel filters the same way as file-based filters.
This doesn't require any additional changes in the drivers.

Reported-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Fixes: c60f83b8 ("perf, pt, coresight: Fix address filters for vmas with non-zero offset")
Link: https://lkml.kernel.org/r/20190329091212.29870-1-alexander.shishkin@linux.intel.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 5f843ed4

kernel/events/core.c

+21 −16

Original line number	Diff line number	Diff line
		@@ -9077,26 +9077,29 @@ static void perf_event_addr_filters_apply(struct perf_event *event)
		if (task == TASK_TOMBSTONE)
		return;

		if (!ifh->nr_file_filters)
		return;

		if (ifh->nr_file_filters) {
		mm = get_task_mm(event->ctx->task);
		if (!mm)
		goto restart;

		down_read(&mm->mmap_sem);
		}

		raw_spin_lock_irqsave(&ifh->lock, flags);
		list_for_each_entry(filter, &ifh->list, entry) {
		if (filter->path.dentry) {
		/*
		* Adjust base offset if the filter is associated to a
		* binary that needs to be mapped:
		*/
		event->addr_filter_ranges[count].start = 0;
		event->addr_filter_ranges[count].size = 0;

		/*
		* Adjust base offset if the filter is associated to a binary
		* that needs to be mapped:
		*/
		if (filter->path.dentry)
		perf_addr_filter_apply(filter, mm, &event->addr_filter_ranges[count]);
		} else {
		event->addr_filter_ranges[count].start = filter->offset;
		event->addr_filter_ranges[count].size = filter->size;
		}

		count++;
		}
		@@ -9104,9 +9107,11 @@ static void perf_event_addr_filters_apply(struct perf_event *event)
		event->addr_filters_gen++;
		raw_spin_unlock_irqrestore(&ifh->lock, flags);

		if (ifh->nr_file_filters) {
		up_read(&mm->mmap_sem);

		mmput(mm);
		}

		restart:
		perf_event_stop(event, 1);

Admin message