Commit 52925434 authored by Gal Pressman's avatar Gal Pressman Committed by Doug Ledford
Browse files

RDMA/efa: Fix success return value in case of error 



Existing code would mistakenly return success in case of error instead
of a proper return value.

Fixes: e9c6c537 ("RDMA/efa: Add common command handlers")
Reviewed-by: default avatarFiras JahJah <firasj@amazon.com>
Reviewed-by: default avatarYossi Leybovich <sleybo@amazon.com>
Signed-off-by: default avatarGal Pressman <galpress@amazon.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 942a8993

drivers/infiniband/hw/efa/efa_com_cmd.c

+18 −6
Original line number Diff line number Diff line
@@ -139,9 +139,11 @@ int efa_com_destroy_qp(struct efa_com_dev *edev, 
			       sizeof(qp_cmd),

			       (struct efa_admin_acq_entry *)&cmd_completion,

			       sizeof(cmd_completion));

	if (err)

	if (err) {

		ibdev_err(edev->efa_dev, "Failed to destroy qp-%u [%d]\n",

			  qp_cmd.qp_handle, err);

		return err;

	}



	return 0;

}
@@ -199,9 +201,11 @@ int efa_com_destroy_cq(struct efa_com_dev *edev, 
			       (struct efa_admin_acq_entry *)&destroy_resp,

			       sizeof(destroy_resp));



	if (err)

	if (err) {

		ibdev_err(edev->efa_dev, "Failed to destroy CQ-%u [%d]\n",

			  params->cq_idx, err);

		return err;

	}



	return 0;

}
@@ -273,10 +277,12 @@ int efa_com_dereg_mr(struct efa_com_dev *edev, 
			       sizeof(mr_cmd),

			       (struct efa_admin_acq_entry *)&cmd_completion,

			       sizeof(cmd_completion));

	if (err)

	if (err) {

		ibdev_err(edev->efa_dev,

			  "Failed to de-register mr(lkey-%u) [%d]\n",

			  mr_cmd.l_key, err);

		return err;

	}



	return 0;

}
@@ -327,9 +333,11 @@ int efa_com_destroy_ah(struct efa_com_dev *edev, 
			       sizeof(ah_cmd),

			       (struct efa_admin_acq_entry *)&cmd_completion,

			       sizeof(cmd_completion));

	if (err)

	if (err) {

		ibdev_err(edev->efa_dev, "Failed to destroy ah-%d pd-%d [%d]\n",

			  ah_cmd.ah, ah_cmd.pd, err);

		return err;

	}



	return 0;

}
@@ -387,10 +395,12 @@ static int efa_com_get_feature_ex(struct efa_com_dev *edev, 
			       get_resp,

			       sizeof(*get_resp));



	if (err)

	if (err) {

		ibdev_err(edev->efa_dev,

			  "Failed to submit get_feature command %d [%d]\n",

			  feature_id, err);

		return err;

	}



	return 0;

}
@@ -534,10 +544,12 @@ static int efa_com_set_feature_ex(struct efa_com_dev *edev, 
			       (struct efa_admin_acq_entry *)set_resp,

			       sizeof(*set_resp));



	if (err)

	if (err) {

		ibdev_err(edev->efa_dev,

			  "Failed to submit set_feature command %d error: %d\n",

			  feature_id, err);

		return err;

	}



	return 0;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE