cpu: Make CPU-offline idle-loop transition point more precise (528a25b0) · Commits · 戴 / test

This commit uses a per-CPU variable to make the CPU-offline code path through the idle loop more precise, so that the outgoing CPU is guaranteed to make it into the idle loop before it is powered off. This commit is in preparation for putting the RCU offline-handling code on this code path, which will eliminate the magic one-jiffy wait that RCU uses as the maximum time for an outgoing CPU to get all the way through the scheduler. The magic one-jiffy wait for incoming CPUs remains a separate issue. Signed-off-by:

Paul E. McKenney <paulmck@linux.vnet.ibm.com>

kernel/cpu.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -408,8 +408,10 @@ static int __ref _cpu_down(unsigned int cpu, int tasks_frozen)
		*
		* Wait for the stop thread to go away.
		*/
		while (!idle_cpu(cpu))
		while (!per_cpu(cpu_dead_idle, cpu))
		cpu_relax();
		smp_mb(); /* Read from cpu_dead_idle before __cpu_die(). */
		per_cpu(cpu_dead_idle, cpu) = false;

		/* This actually kills the CPU. */
		__cpu_die(cpu);

kernel/sched/idle.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -198,6 +198,8 @@ exit_idle:
		start_critical_timings();
		}

		DEFINE_PER_CPU(bool, cpu_dead_idle);

		/*
		* Generic idle loop implementation
		*
		@@ -222,8 +224,11 @@ static void cpu_idle_loop(void)
		check_pgt_cache();
		rmb();

		if (cpu_is_offline(smp_processor_id()))
		if (cpu_is_offline(smp_processor_id())) {
		smp_mb(); /* all activity before dead. */
		this_cpu_write(cpu_dead_idle, true);
		arch_cpu_idle_dead();
		}

		local_irq_disable();
		arch_cpu_idle_enter();

Admin message