Commit 52870d50 authored by Steve French's avatar Steve French
Browse files

smb3: cleanup some recent endian errors spotted by updated sparse 



Now that sparse has been fixed, it spotted a couple recent minor
endian errors (and removed one additional sparse warning).

Thanks to Luc Van Oostenryck for his help fixing sparse.

Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
Reviewed-by: default avatarRonnie Sahlberg <lsahlber@redhat.com>
parent da0c9ea1

fs/cifs/connect.c

+1 −1
Original line number Diff line number Diff line
@@ -4264,7 +4264,7 @@ static int mount_get_conns(struct smb_vol *vol, struct cifs_sb_info *cifs_sb, 
		server->ops->qfs_tcon(*xid, tcon);

		if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_RO_CACHE) {

			if (tcon->fsDevInfo.DeviceCharacteristics &

			    FILE_READ_ONLY_DEVICE)

			    cpu_to_le32(FILE_READ_ONLY_DEVICE))

				cifs_dbg(VFS, "mounted to read only share\n");

			else if ((cifs_sb->mnt_cifs_flags &

				  CIFS_MOUNT_RW_CACHE) == 0)

fs/cifs/smb2pdu.c

+2 −1
Original line number Diff line number Diff line
@@ -3217,7 +3217,8 @@ SMB2_notify_init(const unsigned int xid, struct smb_rqst *rqst, 


	req->PersistentFileId = persistent_fid;

	req->VolatileFileId = volatile_fid;

	req->OutputBufferLength = SMB2_MAX_BUFFER_SIZE - MAX_SMB2_HDR_SIZE;

	req->OutputBufferLength =

		cpu_to_le32(SMB2_MAX_BUFFER_SIZE - MAX_SMB2_HDR_SIZE);

	req->CompletionFilter = cpu_to_le32(completion_filter);

	if (watch_tree)

		req->Flags = cpu_to_le16(SMB2_WATCH_TREE);

fs/cifs/smb2proto.h

+4 −0
Original line number Diff line number Diff line
@@ -150,6 +150,10 @@ extern int SMB2_ioctl_init(struct cifs_tcon *tcon, struct smb_rqst *rqst, 
			   bool is_fsctl, char *in_data, u32 indatalen,

			   __u32 max_response_size);

extern void SMB2_ioctl_free(struct smb_rqst *rqst);

extern int SMB2_change_notify(const unsigned int xid, struct cifs_tcon *tcon,

			u64 persistent_fid, u64 volatile_fid, bool watch_tree,

			u32 completion_filter);



extern int SMB2_close(const unsigned int xid, struct cifs_tcon *tcon,

		      u64 persistent_file_id, u64 volatile_file_id);

extern int SMB2_close_flags(const unsigned int xid, struct cifs_tcon *tcon,

CRA Git | Maintained and supported by SUSTech CRA and CCSE