gpio: omap: Get rid of pm_runtime_irq_safe() (5284521a) · Commits · 戴 / test

If a gpio instance has any GPIO bits requested we do a pm_runtime_get() on the device. Now with cpu_pm handling the deeper SoC idle state quirks, let's just remove pm_runtime_irq_safe() call and add a warning in case we ever happen to encounter it. Cc: Aaro Koskinen <aaro.koskinen@iki.fi> Cc: Keerthy <j-keerthy@ti.com> Cc: Ladislav Michl <ladis@linux-mips.org> Cc: Tero Kristo <t-kristo@ti.com> Signed-off-by:

Tony Lindgren <tony@atomide.com> Acked-by:

Grygorii Strashko <grygorii.strashko@ti.com> Signed-off-by:

Linus Walleij <linus.walleij@linaro.org>

drivers/gpio/gpio-omap.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -763,7 +763,9 @@ static irqreturn_t omap_gpio_irq_handler(int irq, void *gpiobank)
		if (WARN_ON(!isr_reg))
		goto exit;

		pm_runtime_get_sync(bank->chip.parent);
		if (WARN_ONCE(!pm_runtime_active(bank->chip.parent),
		"gpio irq%i while runtime suspended?\n", irq))
		return IRQ_NONE;

		while (1) {
		raw_spin_lock_irqsave(&bank->lock, lock_flags);
		@@ -814,7 +816,6 @@ static irqreturn_t omap_gpio_irq_handler(int irq, void *gpiobank)
		}
		}
		exit:
		pm_runtime_put(bank->chip.parent);
		return IRQ_HANDLED;
		}

		@@ -1466,7 +1467,6 @@ static int omap_gpio_probe(struct platform_device *pdev)
		platform_set_drvdata(pdev, bank);

		pm_runtime_enable(dev);
		pm_runtime_irq_safe(dev);
		pm_runtime_get_sync(dev);

		if (bank->is_mpuio)

Admin message