Commit 52755b66 authored Nov 10, 2020 by Wang Hai Committed by Jakub Kicinski Nov 11, 2020

cosa: Add missing kfree in error path of cosa_write



If memory allocation for 'kbuf' succeed, cosa_write() doesn't have a
corresponding kfree() in exception handling. Thus add kfree() for this
function implementation.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
Acked-by: Jan "Yenya" Kasprzak <kas@fi.muni.cz>
Link: https://lore.kernel.org/r/20201110144614.43194-1-wanghai38@huawei.com


Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent 460cd17e

drivers/net/wan/cosa.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -889,6 +889,7 @@ static ssize_t cosa_write(struct file *file,
		chan->tx_status = 1;
		spin_unlock_irqrestore(&cosa->lock, flags);
		up(&chan->wsem);
		kfree(kbuf);
		return -ERESTARTSYS;
		}
		}

Admin message