nvmet: configfs code cleanup (527123c7) · Commits · 戴 / test

This is a pure code cleanup patch which does not change any functionality. This patch removes the extra lines, get rid of else which is duplicate for return. Reviewed-by:

Christoph Hellwig <hch@lst.de> Signed-off-by:

Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> Signed-off-by:

Keith Busch <kbusch@kernel.org>

drivers/nvme/target/configfs.c

+4 −7

Original line number	Diff line number	Diff line
		@@ -395,14 +395,12 @@ static ssize_t nvmet_ns_device_uuid_store(struct config_item *item,
		struct nvmet_subsys *subsys = ns->subsys;
		int ret = 0;


		mutex_lock(&subsys->lock);
		if (ns->enabled) {
		ret = -EBUSY;
		goto out_unlock;
		}


		if (uuid_parse(page, &ns->uuid))
		ret = -EINVAL;

		@@ -815,7 +813,7 @@ static ssize_t nvmet_subsys_attr_version_show(struct config_item *item,
		(int)NVME_MAJOR(subsys->ver),
		(int)NVME_MINOR(subsys->ver),
		(int)NVME_TERTIARY(subsys->ver));
		else

		return snprintf(page, PAGE_SIZE, "%d.%d\n",
		(int)NVME_MAJOR(subsys->ver),
		(int)NVME_MINOR(subsys->ver));
		@@ -828,7 +826,6 @@ static ssize_t nvmet_subsys_attr_version_store(struct config_item *item,
		int major, minor, tertiary = 0;
		int ret;


		ret = sscanf(page, "%d.%d.%d\n", &major, &minor, &tertiary);
		if (ret != 2 && ret != 3)
		return -EINVAL;

Admin message