Commit 526bb57a authored Apr 09, 2019 by Lorenzo Bianconi Committed by David S. Miller Apr 11, 2019

net: fou: remove redundant code in gue_udp_recv



Remove not useful protocol version check in gue_udp_recv since just
gue version 0 can hit that code. Moreover remove duplicated hdrlen
computation

Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent c9d52f21

net/ipv4/fou.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -170,9 +170,7 @@ static int gue_udp_recv(struct sock sk, struct sk_buff skb)
		/* guehdr may change after pull */
		guehdr = (struct guehdr *)&udp_hdr(skb)[1];

		hdrlen = sizeof(struct guehdr) + optlen;

		if (guehdr->version != 0 \|\| validate_gue_flags(guehdr, optlen))
		if (validate_gue_flags(guehdr, optlen))
		goto drop;

		hdrlen = sizeof(struct guehdr) + optlen;

Admin message